-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
devtools: Fix source contents tests and fix a race #38359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
atbrakhi
approved these changes
Jul 30, 2025
f71283d to
b5371fe
Compare
Co-authored-by: atbrakhi <atbrakhi@igalia.com> Signed-off-by: Delan Azabani <dazabani@igalia.com>
b5371fe to
db3ce47
Compare
minghuaw
pushed a commit
to minghuaw/servo
that referenced
this pull request
Aug 1, 2025
test_sources_list() relied on <https://servo.org/js/load-table.js> to test scripts loaded from multiple origins, but that file was deleted a couple of weeks ago. this patch adds a second internal web server, then replaces that load with scripts loaded from two distinct origins: <http://127.0.0.1:10000> and <http://127.0.0.1:10001>. fixing that test revealed an impl bug where inline module scripts containing `import` statements may never get their source contents populated. this is because the logic for populating source contents for inline scripts only applied to source actors created *before* we finished parsing the page. we assumed that inline scripts always block the parser, but this is not the case. this patch ensures that inline source contents can be populated for source actors created after parse. Testing: adds a new test, test_source_content_with_inline_module_import_external() Fixes: part of servo#36325 Signed-off-by: Delan Azabani <dazabani@igalia.com> Co-authored-by: atbrakhi <atbrakhi@igalia.com>
delan
added a commit
that referenced
this pull request
Aug 7, 2025
Co-authored-by: atbrakhi <atbrakhi@igalia.com> Signed-off-by: Delan Azabani <dazabani@igalia.com>
delan
added a commit
that referenced
this pull request
Aug 7, 2025
Co-authored-by: atbrakhi <atbrakhi@igalia.com> Signed-off-by: Delan Azabani <dazabani@igalia.com>
delan
added a commit
that referenced
this pull request
Aug 7, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
in #38359, we intended to land some fixes to the devtools tests, but we failed to actually include those fixes in the patch. this patch adds a second internal web server, then reworks test_sources_list() to load scripts from the two distinct origins of our internal web servers: <http://127.0.0.1:10000> and <http://127.0.0.1:10001>. Testing: covered by existing devtools tests, which now actually pass Fixes: part of #36325 --------- Signed-off-by: Delan Azabani <dazabani@igalia.com> Co-authored-by: atbrakhi <atbrakhi@igalia.com>
PotatoCP
added a commit
to PotatoCP/servo
that referenced
this pull request
Aug 8, 2025
…38516) (wd) {"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "build_args": "", "wpt_args": "./tests/wpt/tests/webdriver/tests/classic/ --product servodriver --headless --processes 1", "number_of_wpt_chunks": 2}]}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_sources_list() relied on https://servo.org/js/load-table.js to test scripts loaded from multiple origins, but that file was deleted a couple of weeks ago. this patch adds a second internal web server, then replaces that load with scripts loaded from two distinct origins: http://127.0.0.1:10000 and http://127.0.0.1:10001.
fixing that test revealed an impl bug where inline module scripts containing
importstatements may never get their source contents populated. this is because the logic for populating source contents for inline scripts only applied to source actors created before we finished parsing the page. we assumed that inline scripts always block the parser, but this is not the case. this patch ensures that inline source contents can be populated for source actors created after parse.Testing: adds a new test, test_source_content_with_inline_module_import_external()
Fixes: part of #36325