Support calc() values in CSS Grid
#34846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#12631753246) for Linux WPT |
b136316 to
320c9ff
Compare
|
🔨 Triggering try run (#12643671693) for Linux WPT |
|
🔨 Triggering try run (#12643817737) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#12643817737): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (10)
Stable unexpected results (6)
|
|
|
|
🔨 Triggering try run (#12680825926) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#12680825926): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (8)
Stable unexpected results (5)
|
|
|
|
🔨 Triggering try run (#12681297721) for Linux WPT |
|
🔨 Triggering try run (#12681370403) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#12681370403): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (12)
|
|
✨ Try run (#12681370403) succeeded. |
Contributor
|
Based on the number of issues that are referring to this PR and the apparent websites that would visually look okay, this seems like a high value PR to me. I understand that it is blocked on the |
Signed-off-by: Nico Burns <nico@nicoburns.com>
Contributor
Author
|
My proposal would simply be to merge it as-is. Perhaps with some clarification to the SAFETY comment on the The comment at #34846 (comment) is still relevant. It is theoretically possible to make the Taffy API safe, and long-term I think it makes sense to make that happen (esp. as some similar changes would help with enabling parallel layout in Taffy). But it's a large piece of work (I'd estimate at least a couple of weeks, with risk of more if the initial versions causes performance regressions) for something that is a pure refactor (no additional functionality would be enabled), and I can't justify spending my time on that in the short term. If someone else wants to look it I can point them in the right direction. Finishing off DioxusLabs/taffy#855 would likely be the first piece. |
|
🔨 Triggering try run (#19377414882) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19377414882): Flaky unexpected result (41)
Stable unexpected results that are known to be intermittent (33)
Stable unexpected results (5)
|
|
|
Member
Seems reasonable. I will try to review soon. |
mrobinson
approved these changes
Nov 14, 2025
Signed-off-by: Nico Burns <nico@nicoburns.com>
Contributor
Author
|
The failing subtest is for |
|
🔨 Triggering try run (#19378334520) for Linux (WPT) |
Contributor
Author
That was very soon! |
|
Test results for linux-wpt from try job (#19378334520): Flaky unexpected result (39)
Stable unexpected results that are known to be intermittent (29)
|
|
✨ Try run (#19378334520) succeeded. |
Contributor
|
That was a lot quicker than I had expected. Glad to see this land, thanks folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
calc()integration stylo#104In addition to that a
resolve_calc_valuefunction has been added which resolves calc values during the layout process once a percentage resolution basis is available.There is 1 newly failing test and 1 newly failing subtest here.These issues have now been fixed.There are 8 new subtest failures in
css/css-grid/grid-definition/grid-minimum-contribution-with-percentages.html. These are genuine failures, but are unrelated to the calc implementation. The calc implementation is just exposing a pre-existing bug around percentage resolution that also now correctly also applies tocalc()values containing percentages. The fix for would best be done in a followup as it requires teaching Taffy about "compressible replaced elements". (update: I have this implemented but in the interest of keeping it to one feature per PR I have not included it here)./mach build -ddoes not report any errors./mach test-tidydoes not report any errors. It doesn't like the git dependency on Taffy.