Add stub interface for AbortController#34519
Merged
jdm merged 1 commit intoservo:mainfrom Dec 10, 2024
Merged
Conversation
wusyong
reviewed
Dec 7, 2024
4b1e030 to
8982120
Compare
Co-authored-by: syvb <me@iter.ca> Signed-off-by: Josh Matthews <josh@joshmatthews.net>
8982120 to
89dca5e
Compare
mrobinson
approved these changes
Dec 10, 2024
d-desiatkin
pushed a commit
to d-desiatkin/servo
that referenced
this pull request
Dec 11, 2024
Signed-off-by: Josh Matthews <josh@joshmatthews.net> Co-authored-by: syvb <me@iter.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes the simplest changes from #32871 and puts the interface behind a pref so we can experiment with loading pages that require the interface's presence (eg. github and discord). I am able to successfully interact with the discord login page with
--pref dom.svg.enabledand--pref dom.abort_controller.enabledapplied../mach build -ddoes not report any errors./mach test-tidydoes not report any errors