Support HTML parser reentrancy by jdm · Pull Request #32820 · servo/servo

jdm · 2024-07-20T17:51:14Z

These changes adjust the Servo parser implementations to match the interface changes in https://github.com/servo/html5ever/tree/no-mut-interface. Additionally, we can now remove the assertions around active parsers when invoking arbitrary JS (added in #19307) since our parser is now reentrant.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix HTML parser does not support reentrancy via custom elements #32454 and fix Intermittent double mutable borrow when GC occurs during synchronous parsing #32646 and fix tweakers.net servo crash - assertion failed: window.Document ().can invoke script() #32744 and fix Borrow hazard when calling Tokenizer::end from ServoParser::do_parse_sync #24115.
There are tests for these changes

github-actions · 2024-07-20T17:51:33Z

🔨 Triggering try run (#10022044653) for Linux WPT

github-actions · 2024-07-20T17:55:24Z

⚠️ Try run (#10022044653) failed.

github-actions · 2024-07-20T19:03:00Z

🔨 Triggering try run (#10022447770) for Linux WPT

github-actions · 2024-07-20T19:37:32Z

⚠️ Try run (#10022447770) failed.

github-actions · 2024-07-20T20:36:48Z

🔨 Triggering try run (#10022953584) for Linux WPT

github-actions · 2024-07-20T21:13:16Z

Test results for linux-wpt-layout-2020 from try job (#10022953584):

Flaky unexpected result (17)

FAIL [expected PASS] /css/css-sizing/dynamic-available-size-iframe.html (#31559)
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
TIMEOUT /fetch/metadata/generated/element-img-environment-change.https.sub.html (#30111)
- FAIL [expected TIMEOUT] subtest: sec-fetch-site - Cross-site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- TIMEOUT [expected NOTRUN] subtest: sec-fetch-site - Same site, no attributes
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- FAIL [expected PASS] subtest: Check execution order from nested timeout
```
assert_equals: Expected nested setTimeout to run second expected true but got false
```
- FAIL [expected PASS] subtest: Check execution order on load handler
```
assert_equals: Expected onload to run first expected false but got true
```
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
- TIMEOUT [expected FAIL] subtest: Navigating to a different document with link click
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Navigating to a different document with form submission
CRASH [expected OK] /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html (#32745)
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: \n in name (normal form)
- PASS [expected FAIL] subtest: text/plain: \r\n in name (formdata event)
CRASH [expected OK] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730)
OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
- PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
OK /html/webappapis/dynamic-markup-insertion/document-write/module-tla-delayed.html (#29137)
- FAIL [expected PASS] subtest: document.write in an imported module
```
assert_true: onload must be called expected true got false
```
TIMEOUT [expected CRASH] /html/webappapis/dynamic-markup-insertion/opening-the-input-stream/ignore-opens-during-unload.window.html (#21444)
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- PASS [expected FAIL] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document
TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank
```
Test timed out
```
TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank
```
Test timed out
```

Stable unexpected results that are known to be intermittent (15)

FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '500' over '400 425'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique -20deg' should prefer 'oblique 30deg 60deg' over 'oblique 40deg 50deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
TIMEOUT /css/cssom-view/MediaQueryList-addListener-handleEvent.html (#24571)
- PASS [expected TIMEOUT] subtest: looks up handleEvent method on every event dispatch
- TIMEOUT [expected NOTRUN] subtest: doesn't look up handleEvent method on callable event listeners
```
Test timed out
```
TIMEOUT /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- TIMEOUT [expected PASS] subtest: listeners are called correct number of times
```
Test timed out
```
- NOTRUN [expected PASS] subtest: listeners are called in order they were added
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
```
TIMEOUT [expected ERROR] /html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html (#32745)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- TIMEOUT [expected FAIL] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
Test timed out
```
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Element with tabindex should support autofocus
```
assert_equals: expected "SPAN" but got "BODY"
```
- TIMEOUT [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
```
Test timed out
```
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: \r\n in value (normal form)
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task
```
Test timed out
```
CRASH [expected OK] /url/failure.html (#28574)
OK /workers/WorkerGlobalScope-close.html (#23064)
- PASS [expected FAIL] subtest: Test sending a message after closing.

github-actions · 2024-07-20T21:13:26Z

✨ Try run (#10022953584) succeeded.

github-actions · 2024-07-27T07:02:36Z

🔨 Triggering try run (#10121702665) for Linux WPT

github-actions · 2024-07-27T07:03:37Z

🔨 Triggering try run (#10121710845) for Linux WPT

github-actions · 2024-07-27T07:45:29Z

🔨 Triggering try run (#10121946213) for Linux WPT

github-actions · 2024-07-27T07:45:55Z

⚠️ Try run (#10121710845) failed.

github-actions · 2024-07-27T08:16:34Z

Test results for linux-wpt-layout-2020 from try job (#10121946213):

Flaky unexpected result (22)

FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
CRASH [expected PASS] /_mozilla/mozilla/webgl/clearcolor.html
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'oblique 40deg 50deg' over 'oblique 5deg 10deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'oblique 5deg 10deg' over 'oblique 5deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'oblique 0deg' over 'oblique -60deg -30deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 20deg' should prefer 'oblique 40deg 50deg' over 'oblique 10deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique -10deg' should prefer 'oblique -5deg' over 'oblique -1deg 0deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique -10deg' should prefer 'oblique 0deg 10deg' over 'oblique 40deg 50deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
TIMEOUT /css/cssom-view/MediaQueryList-extends-EventTarget-interop.html (#25285)
- TIMEOUT [expected PASS] subtest: listener added with addListener and addEventListener is called once
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: listener added with addListener and addEventListener (capture) is called twice
TIMEOUT /css/cssom-view/MediaQueryList-extends-EventTarget.html (#25269)
- TIMEOUT [expected PASS] subtest: onchange removes listener
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: listeners for "change" type are called
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
CRASH [expected OK] /html/browsers/browsing-the-web/unloading-documents/prompt-and-unload-script-closeable.html
ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html (#32745)
CRASH [expected FAIL] /html/canvas/element/manual/imagebitmap/imageBitmapRendering-transferFromImageBitmap-webgl.html
TIMEOUT [expected OK] /html/semantics/document-metadata/the-base-element/base_target_does_not_affect_location_assignment.html (#32615)
- TIMEOUT [expected PASS] subtest: base_target_does_not_affect_location_assignment
```
Test timed out
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-cross-site.tentative.sub.window.html (#31754)
- TIMEOUT [expected FAIL] subtest: A cross-site unsandboxed iframe navigation consumes user activation and disallows top-level navigation.
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: \r\n in value (formdata event)
OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- PASS [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load
OK /html/webappapis/dynamic-markup-insertion/document-write/module-delayed.html (#27659)
- FAIL [expected PASS] subtest: async document.write in a module
```
assert_true: onload must be called expected true got false
```
OK /quirks/percentage-height-calculation.html
- FAIL [expected PASS] subtest: The percentage height calculation quirk, #foo { height:100px } #test { height:100%; position:absolute }<div id=foo><div><div id=test></div></div></div>
```
assert_equals: quirks mode expected "200px" but got "0px"
```
- FAIL [expected PASS] subtest: The percentage height calculation quirk, #foo { height:100px } #test { height:100%; position:fixed }<div id=foo><div><div id=test></div></div></div>
```
assert_equals: quirks mode expected "200px" but got "0px"
```
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
```
assert_equals: expected 8529408 but got 8529664
```
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```
OK /workers/WorkerGlobalScope-close.html (#23064)
- PASS [expected FAIL] subtest: Test sending a message after closing.
OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)
OK /xhr/xhr-timeout-longtask.any.html (#27663)
- FAIL [expected PASS] subtest: Long tasks should not trigger load timeout
```
assert_unreached: [object ProgressEvent] Reached unreachable code
```

Stable unexpected results that are known to be intermittent (14)

OK [expected TIMEOUT] /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- FAIL [expected NOTRUN] subtest: listener that was added twice is called only once
```
assert_equals: expected 1 but got 0
```
- FAIL [expected NOTRUN] subtest: listeners are called in order their MQLs were created
```
assert_array_equals: lengths differ, expected array ["mql1", "mql2"] length 2, got [] length 0
```
- FAIL [expected NOTRUN] subtest: removing listener from one MQL doesn't remove it from all MQLs
```
assert_equals: expected 1 but got 0
```
- PASS [expected NOTRUN] subtest: MediaQueryList::removeListener removes added listener
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-user
TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-origin destination, no attributes
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
- PASS [expected FAIL] subtest: Navigating to a different document with link click
- PASS [expected FAIL] subtest: Navigating to a different document with form submission
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
```
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected ERROR] /html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html (#32745)
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Element with tabindex should support autofocus
```
assert_equals: expected "SPAN" but got "BODY"
```
- TIMEOUT [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
```
Test timed out
```
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
Test timed out
```
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task
```
Test timed out
```

Stable unexpected results (6)

CRASH [expected OK] /html/semantics/scripting-1/the-script-element/execution-timing/041.html
CRASH [expected OK] /html/syntax/parsing/html5lib_scripted_webkit01.html?run_type=uri
CRASH [expected OK] /html/webappapis/dynamic-markup-insertion/document-write/script_003.html
CRASH [expected OK] /html/webappapis/dynamic-markup-insertion/document-write/script_004.html
CRASH [expected OK] /html/webappapis/dynamic-markup-insertion/document-write/script_009.html
CRASH [expected OK] /html/webappapis/dynamic-markup-insertion/document-write/script_012.html

github-actions · 2024-07-27T08:16:45Z

⚠️ Try run (#10121946213) failed.

github-actions · 2024-07-28T02:33:34Z

🔨 Triggering try run (#10128298816) for Linux WPT

github-actions · 2024-07-28T03:04:28Z

Test results for linux-wpt-layout-2020 from try job (#10128298816):

Flaky unexpected result (17)

OK /css/css-values/calc-in-media-queries-with-mixed-units.html (#31731)
- FAIL [expected PASS] subtest: box should be orange if the calc between vh+px in @media was correct
```
assert_equals: expected "rgb(255, 165, 0)" but got "rgb(0, 0, 255)"
```
TIMEOUT /css/cssom-view/MediaQueryList-addListener-handleEvent.html (#24571)
- PASS [expected TIMEOUT] subtest: looks up handleEvent method on every event dispatch
- TIMEOUT [expected NOTRUN] subtest: doesn't look up handleEvent method on callable event listeners
```
Test timed out
```
TIMEOUT /css/cssom-view/MediaQueryList-extends-EventTarget.html (#25269)
- TIMEOUT [expected PASS] subtest: onchange removes listener
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: listeners for "change" type are called
OK [expected TIMEOUT] /css/cssom-view/MediaQueryListEvent.html (#25275)
- PASS [expected TIMEOUT] subtest: argument of onchange
- FAIL [expected NOTRUN] subtest: constructor of "change" event
```
assert_true: expected true got false
```
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Single value - name is missing
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored
```
promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
```
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
- FAIL [expected PASS] subtest: DOMParser
```
assert_unreached: got unexpected load event Reached unreachable code
```
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: \r\n in value (formdata event)
CRASH [expected OK] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730)
OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
- PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:
```
Test timed out
```
OK /workers/WorkerGlobalScope-close.html (#23064)
- PASS [expected FAIL] subtest: Test sending a message after closing.

Stable unexpected results that are known to be intermittent (13)

FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
TIMEOUT /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- TIMEOUT [expected PASS] subtest: listeners are called in order they were added
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
- PASS [expected FAIL] subtest: Navigating to a different document with form submission
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
```
ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-invalid-args.html (#32745)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- TIMEOUT [expected FAIL] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
Test timed out
```
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Element with tabindex should support autofocus
```
assert_equals: expected "SPAN" but got "BODY"
```
- PASS [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus
```
promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
```
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
```
promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
```
- FAIL [expected NOTRUN] subtest: Area element should support autofocus
```
promise_test: Unhandled rejection with value: object "TypeError: w.document.querySelector(...) is null"
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
```
assert_equals: expected 5974272 but got 5974528
```

Stable unexpected results (1)

TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```

github-actions · 2024-07-28T03:04:38Z

⚠️ Try run (#10128298816) failed.

jdm · 2024-08-10T02:17:11Z

These changes are now ready for review.

sagudev · 2024-08-10T10:22:37Z

error[E0308]: mismatched types
   --> components/fonts/tests/font_context.rs:167:19
    |
167 |             list: names.into_boxed_slice(),
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^ expected `ArcSlice<SingleFontFamily>`, found `Box<[SingleFontFamily]>`
    |
    = note: expected struct `ArcSlice<SingleFontFamily>`
               found struct `std::boxed::Box<[SingleFontFamily]>`

gterzian

LGTM, with a few questions.

tests/wpt/mozilla/tests/mozilla/parser-reentrancy-customelement.html

components/script/dom/servoparser/async_html.rs

jdm · 2024-08-16T03:34:15Z

Bah, more changes from servo/stylo@33c2664 that are blocking this PR. I'm going to try to extract those to a separate PR.

jdm · 2024-08-16T03:43:24Z

Once #33079 merges this will (hopefully) be able to finally merge after a rebase.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

jdm added the T-linux-wpt Do a try run of the WPT label Jul 20, 2024

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jul 20, 2024

jdm added the T-linux-wpt Do a try run of the WPT label Jul 20, 2024

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jul 20, 2024

jdm added the T-linux-wpt Do a try run of the WPT label Jul 20, 2024

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jul 20, 2024

jdm added the T-linux-wpt Do a try run of the WPT label Jul 27, 2024

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jul 27, 2024

jdm added the T-linux-wpt Do a try run of the WPT label Jul 27, 2024

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jul 27, 2024

jdm added the T-linux-wpt Do a try run of the WPT label Jul 27, 2024

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jul 27, 2024

jdm added the T-linux-wpt Do a try run of the WPT label Jul 28, 2024

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jul 28, 2024

jdm marked this pull request as ready for review August 10, 2024 02:16

jdm requested a review from gterzian as a code owner August 10, 2024 02:16

jdm force-pushed the no-mut-parser branch from 3cea181 to 4d8875a Compare August 10, 2024 15:36

gterzian approved these changes Aug 12, 2024

View reviewed changes

tests/wpt/mozilla/tests/mozilla/parser-reentrancy-customelement.html Outdated Show resolved Hide resolved

components/script/dom/servoparser/async_html.rs Show resolved Hide resolved

jdm mentioned this pull request Aug 15, 2024

Ensure parsers initiated from DOMParser always complete. #33056

Merged

4 tasks

jdm force-pushed the no-mut-parser branch 2 times, most recently from 881203f to 56979af Compare August 15, 2024 15:15

jdm enabled auto-merge August 15, 2024 15:18

jdm force-pushed the no-mut-parser branch from 56979af to 2c72bd3 Compare August 15, 2024 15:19

jdm added this pull request to the merge queue Aug 15, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 15, 2024

jdm force-pushed the no-mut-parser branch from 2c72bd3 to 88182a8 Compare August 15, 2024 21:44

jdm enabled auto-merge August 15, 2024 21:45

jdm added this pull request to the merge queue Aug 15, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 16, 2024

jdm force-pushed the no-mut-parser branch from 88182a8 to af0243b Compare August 16, 2024 12:31

jdm enabled auto-merge August 16, 2024 12:31

jdm added 4 commits August 16, 2024 11:58

Update parser interface for reentrancy.

6d9b845

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

Remove assertions around invoking scripts with active parser.

260db1e

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

Add regression test.

2724847

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

Run test with normal and async html parser.

ab259d4

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

jdm force-pushed the no-mut-parser branch from af0243b to ab259d4 Compare August 16, 2024 15:58

jdm added this pull request to the merge queue Aug 16, 2024

Merged via the queue into main with commit 4df7a1a Aug 16, 2024

jdm deleted the no-mut-parser branch August 16, 2024 17:31

Uh oh!

Conversation

jdm commented Jul 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 20, 2024

Uh oh!

github-actions bot commented Jul 20, 2024

Uh oh!

github-actions bot commented Jul 20, 2024

Uh oh!

github-actions bot commented Jul 20, 2024

Uh oh!

github-actions bot commented Jul 20, 2024

Uh oh!

github-actions bot commented Jul 20, 2024

Uh oh!

github-actions bot commented Jul 20, 2024

Uh oh!

github-actions bot commented Jul 27, 2024

Uh oh!

github-actions bot commented Jul 27, 2024

Uh oh!

github-actions bot commented Jul 27, 2024

Uh oh!

github-actions bot commented Jul 27, 2024

Uh oh!

github-actions bot commented Jul 27, 2024

Uh oh!

github-actions bot commented Jul 27, 2024

Uh oh!

github-actions bot commented Jul 28, 2024

Uh oh!

github-actions bot commented Jul 28, 2024

Uh oh!

github-actions bot commented Jul 28, 2024

Uh oh!

jdm commented Aug 10, 2024

Uh oh!

sagudev commented Aug 10, 2024

Uh oh!

gterzian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jdm commented Aug 16, 2024

Uh oh!

jdm commented Aug 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jdm commented Jul 20, 2024 •

edited

Loading

jdm commented Aug 16, 2024 •

edited

Loading