Skip to content

Update stylo for latest changes.#33079

Merged
mrobinson merged 1 commit intomainfrom
stylo-changes
Aug 16, 2024
Merged

Update stylo for latest changes.#33079
mrobinson merged 1 commit intomainfrom
stylo-changes

Conversation

@jdm
Copy link
Member

@jdm jdm commented Aug 16, 2024

This updates Servo to account for the changes in servo/stylo@33c2664.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

@jdm jdm requested a review from gterzian as a code owner August 16, 2024 03:42
@jdm jdm added the T-linux-wpt Do a try run of the WPT label Aug 16, 2024
@github-actions github-actions bot removed the T-linux-wpt Do a try run of the WPT label Aug 16, 2024
@github-actions
Copy link

github-actions bot commented Aug 16, 2024

🔨 Triggering try run (#10414301023) for Linux WPT

@jdm jdm mentioned this pull request Aug 16, 2024
Merged
4 tasks
@github-actions
Copy link

github-actions bot commented Aug 16, 2024

⚠️ Try run (#10414301023) failed.

@jdm jdm added the T-linux-wpt Do a try run of the WPT label Aug 16, 2024
@github-actions github-actions bot removed the T-linux-wpt Do a try run of the WPT label Aug 16, 2024
@github-actions
Copy link

github-actions bot commented Aug 16, 2024

🔨 Triggering try run (#10414382429) for Linux WPT

@github-actions
Copy link

github-actions bot commented Aug 16, 2024

Test results for linux-wpt-layout-2020 from try job (#10414382429):

Flaky unexpected result (21)
  • FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
  • CRASH [expected PASS] /_webgl/conformance/glsl/bugs/long-expressions-should-not-crash.html (#19221)
  • TIMEOUT [expected PASS] /css/compositing/mix-blend-mode/mix-blend-mode-video.html (#32763)
  • TIMEOUT [expected PASS] /css/css-color/animation/opacity-animation-ending-correctly-002.html (#29216)
  • OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
    • FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '400 425' over '350 399'

      assert_equals: Unexpected font on test element expected 487 but got 532

    • FAIL [expected PASS] subtest: Matching font-style: 'oblique 21deg' should prefer 'oblique 0deg' over 'oblique -50deg -20deg'

      assert_equals: Unexpected font on test element expected 487 but got 532

  • OK /css/cssom-view/MediaQueryList-extends-EventTarget-interop.html (#25285)
    • FAIL [expected PASS] subtest: listener added with addListener and addEventListener is called once

      assert_equals: triggerMQLEvent expected 1 but got 0

  • OK /css/cssom-view/matchMedia.html (#31428)
    • PASS [expected FAIL] subtest: iframe.matchMedia("(width: 200px)") matches
  • OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
    • PASS [expected FAIL] subtest: Single value - name is missing
    • PASS [expected FAIL] subtest: setFormValue with an empty FormData should submit nothing
  • TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
    • TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up

      Test timed out

  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
    • FAIL [expected PASS] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation

      assert_equals: expected "" but got "#fragment"

  • OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
    • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted

      assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 1 (expected array [6, 3] got [6, 1])

  • OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
    • PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
  • TIMEOUT [expected PASS] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
  • TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
  • TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
    • TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used

      Test timed out

  • TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
    • NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
  • OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
  • OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
    • PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in name (normal form)
    • PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in value (formdata event)
    • PASS [expected FAIL] subtest: application/x-www-form-urlencoded: \r\n in filename (formdata event)
  • OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
    • PASS [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load
  • OK [expected CRASH] /url/failure.html (#28574)
  • OK /workers/WorkerGlobalScope-close.html (#23064)
    • PASS [expected FAIL] subtest: Test sending a message after closing.
Stable unexpected results that are known to be intermittent (9)
  • FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
  • FAIL [expected PASS] /css/css-values/vh_not_refreshing_on_chrome.html (#23385, #15570)
  • TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
    • PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-origin destination, no attributes
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
    • PASS [expected FAIL] subtest: Navigating to a different document with link click
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
    • PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
  • OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
    • PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
  • ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html (#32745)
  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
  • OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
    • PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
Stable unexpected results (9)
  • OK /css/css-images/image-set/image-set-computed.sub.html
    • PASS [expected FAIL] subtest: Property background-image value 'image-set(url(http://web-platform.test/example.png) 1x)'
    • PASS [expected FAIL] subtest: Property background-image value '-webkit-image-set(url(http://web-platform.test/example.png) 1x)'
    • PASS [expected FAIL] subtest: Property background-image value 'image-set(url(http://web-platform.test/example.png) 1x, 'http://web-platform.test/example.png' 2x)'
    • PASS [expected FAIL] subtest: Property background-image value '-webkit-image-set(url(http://web-platform.test/example.png) 1x, 'http://web-platform.test/example.png' 2x)'
    • PASS [expected FAIL] subtest: Property background-image value 'image-set(url("http://web-platform.test/example.png") 1dppx)'
    • PASS [expected FAIL] subtest: Property background-image value '-webkit-image-set(url("http://web-platform.test/example.png") 1dppx)'
    • PASS [expected FAIL] subtest: Property background-image value 'image-set(url(http://web-platform.test/example.png) 48dpi)'
    • PASS [expected FAIL] subtest: Property background-image value '-webkit-image-set(url(http://web-platform.test/example.png) 48dpi)'
    • PASS [expected FAIL] subtest: Property background-image value 'image-set(url(http://web-platform.test/example.png) 2400dpcm, 'http://web-platform.test/example.png' 2x)'
    • PASS [expected FAIL] subtest: Property background-image value '-webkit-image-set(url(http://web-platform.test/example.png) 2400dpcm, 'http://web-platform.test/example.png' 2x)'
    • And 26 more unexpected results...
  • PASS [expected FAIL] /css/css-images/image-set/image-set-negative-resolution-rendering-3.html
  • OK /css/css-images/image-set/image-set-parsing.html
    • PASS [expected FAIL] subtest: e.style['background-image'] = "image-set(url(example.png) 1x)" should set the property value
    • PASS [expected FAIL] subtest: e.style['background-image'] = "-webkit-image-set(url(example.png) 1x)" should set the property value
    • PASS [expected FAIL] subtest: e.style['background-image'] = "image-set('example.jpg' 1x)" should set the property value
    • PASS [expected FAIL] subtest: e.style['background-image'] = "-webkit-image-set('example.jpg' 1x)" should set the property value
    • PASS [expected FAIL] subtest: e.style['background-image'] = "image-set(url(example.png) 1x, 'example.png' 2x)" should set the property value
    • PASS [expected FAIL] subtest: e.style['background-image'] = "-webkit-image-set(url(example.png) 1x, 'example.png' 2x)" should set the property value
    • PASS [expected FAIL] subtest: e.style['background-image'] = "image-set(url(example.png) 1dpcm, 'example.png' 2x)" should set the property value
    • PASS [expected FAIL] subtest: e.style['background-image'] = "-webkit-image-set(url(example.png) 1dpcm, 'example.png' 2x)" should set the property value
    • PASS [expected FAIL] subtest: e.style['background-image'] = "image-set('example.jpeg' 222dpi, url(example.png) 3.5x)" should set the property value
    • PASS [expected FAIL] subtest: e.style['background-image'] = "-webkit-image-set('example.jpeg' 222dpi, url(example.png) 3.5x)" should set the property value
    • And 76 more unexpected results...
  • PASS [expected FAIL] /css/css-images/image-set/image-set-type-unsupported-rendering-2.html
  • PASS [expected FAIL] /css/css-images/image-set/image-set-type-unsupported-rendering.html
  • PASS [expected FAIL] /css/css-images/image-set/image-set-zero-resolution-rendering-2.html
  • PASS [expected FAIL] /css/css-images/image-set/image-set-zero-resolution-rendering.html
  • OK /css/css-ui/parsing/cursor-valid.html
    • PASS [expected FAIL] subtest: e.style['cursor'] = "image-set(\"https://example.com/\" 1x) 5 6, grab" should set the property value
    • PASS [expected FAIL] subtest: e.style['cursor'] = "image-set(\"https://example.com/\" 1x, \"https://example.com/highres\" 2x) 5 6, grab" should set the property value
  • OK /css/css-values/calc-infinity-nan-serialize-resolution.html
    • PASS [expected FAIL] subtest: 'image-set(url("") calc(1x * NaN))' as a specified value should serialize as 'image-set(url("") calc(NaN * 1dppx))'.
    • PASS [expected FAIL] subtest: 'image-set(url("") calc(1x * nan))' as a specified value should serialize as 'image-set(url("") calc(NaN * 1dppx))'.
    • PASS [expected FAIL] subtest: 'image-set(url("") calc(1dppx * NaN))' as a specified value should serialize as 'image-set(url("") calc(NaN * 1dppx))'.
    • PASS [expected FAIL] subtest: 'image-set(url("") calc(1dppx * infinity / infinity))' as a specified value should serialize as 'image-set(url("") calc(NaN * 1dppx))'.
    • PASS [expected FAIL] subtest: 'image-set(url("") calc(1dppx * 0 * infinity))' as a specified value should serialize as 'image-set(url("") calc(NaN * 1dppx))'.
    • PASS [expected FAIL] subtest: 'image-set(url("") calc(1dppx * (infinity + -infinity)))' as a specified value should serialize as 'image-set(url("") calc(NaN * 1dppx))'.
    • PASS [expected FAIL] subtest: 'image-set(url("") calc(1dppx * (-infinity + infinity)))' as a specified value should serialize as 'image-set(url("") calc(NaN * 1dppx))'.
    • PASS [expected FAIL] subtest: 'image-set(url("") calc(1dppx * (infinity - infinity)))' as a specified value should serialize as 'image-set(url("") calc(NaN * 1dppx))'.
    • PASS [expected FAIL] subtest: 'image-set(url("") calc(1dppx * infinity))' as a specified value should serialize as 'image-set(url("") calc(infinity * 1dppx))'.
    • PASS [expected FAIL] subtest: 'image-set(url("") calc(1dppx * -infinity))' as a specified value should serialize as 'image-set(url("") calc(-infinity * 1dppx))'.
    • And 19 more unexpected results...

@github-actions
Copy link

github-actions bot commented Aug 16, 2024

⚠️ Try run (#10414382429) failed.

@mrobinson mrobinson enabled auto-merge August 16, 2024 08:54
@jdm @mrobinson
Update stylo for latest changes.
a27705a 
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
@mrobinson mrobinson added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 3d3621b Aug 16, 2024
@mrobinson mrobinson deleted the stylo-changes branch August 16, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrobinson mrobinson mrobinson approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jdm @mrobinson