Enable debug assertions for all builds other than official releases by delan · Pull Request #30509 · servo/servo

delan · 2023-10-06T09:48:56Z

Servo should ideally never panic (see the discussion in #30458), but we still need a way to detect invalid states when hacking on Servo or testing on CI. Unfortunately our release profile has debug assertions disabled.

This patch enables debug assertions in the release profile, while adding a “production” profile that yields a release build without debug assertions, which we use when building nightly releases. This patch also:

updates HACKING_QUICKSTART to document our profiles
extends mach to accept a --profile argument like Cargo
eliminates the std_test_override hack
hardens Fix running servoshell and unit tests through a symlink #30537 such that we only try the current directory and its ancestors when we aren’t in the production profile

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix Debug assertions don’t do anything on CI #30567

delan · 2023-10-06T10:50:08Z

@bors-servo try

github-actions · 2023-10-06T10:50:22Z

🔨 Triggering try run (#6430688359) with platform=all and layout=all

github-actions · 2023-10-06T12:01:22Z

Test results for linux-wpt-layout-2013 from try job (#6430688359):

Flaky unexpected result (13)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected PASS] /css/css-fonts/font-size-adjust-reload.html
OK /css/cssom-view/MediaQueryList-addListener-handleEvent.html (#24571)
- FAIL [expected PASS] subtest: calls handleEvent method of event listener assert_equals: expected (object) object "[object Object]" but got (undefined) undefined
OK /css/cssom-view/MediaQueryListEvent.html (#25275)
- FAIL [expected PASS] subtest: argument of onchange assert_true: expected true got false
OK /css/cssom-view/offsetTopLeft-border-box.html (#24237)
- FAIL [expected PASS] subtest: container: 0 assert_equals: offsetTop expected 2 but got 0
- FAIL [expected PASS] subtest: container: 1 assert_equals: offsetTop expected 2 but got 0
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: Basic test (formdata event)
OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
- PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- FAIL [expected PASS] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document assert_equals: expected "/html/webappapis/scripting/events/resources/open-window.html" but got "blank"
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
ERROR [expected OK] /workers/constructors/Worker/Worker-constructor.html (#22991)

Stable unexpected results that are known to be intermittent (16)

OK /css/css-fonts/variations/font-weight-matching.html (#20686)
- FAIL [expected PASS] subtest: Test @font-face matching for weight 100 assert_approx_equals: @font-face should be mapped to CSSTest Weights 900. expected 90 +/- 2 but got 180
OK /css/cssom-view/elementFromPoint-list-001.html (#23915)
- PASS [expected FAIL] subtest: <li>Outside 1</li>
OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
- FAIL [expected PASS] subtest: Smooth scrolling while doing history navigation. assert_not_equals: Shouldn't be scrolled to top anymore. got disallowed value 0
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- PASS [expected TIMEOUT] subtest: background-image sec-fetch-dest - Not sent to non-trustworthy same-site destination
- PASS [expected TIMEOUT] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)
- PASS [expected FAIL] subtest: border-image sec-fetch-site - HTTPS downgrade (header not sent)
OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
- FAIL [expected PASS] subtest: 0080 00FF 0100 set in href="" targeting a frame and clicked assert_equals: expected "�ÿĀ" but got ""
- FAIL [expected PASS] subtest: D83D DE0D set in href="" targeting a frame and clicked assert_equals: expected "😍" but got ""
- FAIL [expected PASS] subtest: DE0D 0041 set in href="" targeting a frame and clicked assert_equals: expected "\ufffdA" but got ""
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/browsers/history/the-location-interface/location-protocol-setter.html (#20839)
- PASS [expected FAIL] subtest: Equivalent tests for data URL and srcdoc <iframe>s
OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
- FAIL [expected PASS] subtest: first argument: absolute url assert_equals: should be equal to result url expected "http://web-platform.test:8000/common/blank.html" but got "about:blank"
OK [expected CRASH] /html/canvas/offscreen/the-offscreen-canvas/size.attributes.parse.minus.worker.html (#30164)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
OK /html/webappapis/dynamic-markup-insertion/document-write/module-static-import-delayed.html (#26243)
- PASS [expected FAIL] subtest: document.write in an imported module
PASS [expected CRASH] /streams/readable-streams/crashtests/strategy-worker-terminate.html (#30124)
TIMEOUT [expected OK] /webaudio/the-audio-api/the-audiocontext-interface/audiocontext-not-fully-active.html (#27664)
OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
OK [expected TIMEOUT] /webmessaging/without-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:

github-actions · 2023-10-06T12:04:07Z

Test results for linux-wpt-layout-2020 from try job (#6430688359):

Flaky unexpected result (16)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected FAIL] subtest: Opening a blob URL in a new window immediately before revoking it works. Test timed out
OK /_mozilla/mozilla/task_queue_throttling.any.html (#22519)
- FAIL [expected PASS] subtest: Throttling the performance timeline task queue. assert_true: expected true got false
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT /_webgl/conformance/reading/read-pixels-test.html (#28337)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/rendering/rendering-stencil-large-viewport.html (#28343)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
- FAIL [expected PASS] subtest: D83D DE0D set in href="" targeting a frame and clicked assert_equals: expected "😍" but got ""
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"
OK /html/browsers/browsing-the-web/read-media/pageload-image-in-popup.html (#23849)
- PASS [expected FAIL] subtest: The document for a standalone media file should have one child in the body.
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used Test timed out
OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
- PASS [expected FAIL] subtest: createHTMLDocument
- PASS [expected FAIL] subtest: <template>
OK [expected TIMEOUT] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- PASS [expected TIMEOUT] subtest: reparent-form-during-planned-navigation-task
TIMEOUT [expected OK] /webmessaging/with-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript: Test timed out

Stable unexpected results that are known to be intermittent (17)

OK /css/CSS2/linebox/inline-negative-margin-001.html (#23862)
- PASS [expected FAIL] subtest: [data-expected-height] 2
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '400 425' over '350 399' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-weight: '430' should prefer '501 550' over '502 560'
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '500' over '450 460' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '501' should prefer '501' over '502 510' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '501' should prefer '450 460' over '390 410' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-style: 'normal' should prefer 'normal' over 'oblique 0deg'
- FAIL [expected PASS] subtest: Matching font-style: 'normal' should prefer 'oblique -50deg -20deg' over 'oblique -40deg -30deg' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-style: 'italic' should prefer 'oblique 5deg' over 'normal'
- PASS [expected FAIL] subtest: Matching font-style: 'italic' should prefer 'oblique 0deg' over 'oblique -60deg -30deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 20deg' should prefer 'oblique 10deg' over 'italic'
- And 12 more unexpected results...
OK /css/css-text/white-space/trailing-space-position-001.html (#24585)
- PASS [expected FAIL] subtest: CSS Test: Positions of trailing collapsible spaces 1
- PASS [expected FAIL] subtest: CSS Test: Positions of trailing collapsible spaces 3
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- FAIL [expected PASS] subtest: listeners are called correct number of times assert_equals: expected 5 but got 4
OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
- FAIL [expected TIMEOUT] subtest: Navigating to a different document with form submission assert_equals: expected "http://web-platform.test:8000/common/blank.html?1=" but got "about:blank"
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-load-as-html.xhtml (#29070)
- TIMEOUT [expected PASS] subtest: javascript: URL navigation to a string must create a HTML document using the correct properties Test timed out
OK /html/browsers/history/the-location-interface/location-protocol-setter.html (#20839)
- PASS [expected FAIL] subtest: Equivalent tests for data URL and srcdoc <iframe>s
OK [expected TIMEOUT] /html/browsers/origin/cross-origin-objects/cross-origin-objects.html (#28569)
OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
- FAIL [expected PASS] subtest: first argument: absolute url assert_equals: should be equal to result url expected "http://web-platform.test:8000/common/blank.html" but got "about:blank"
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-top.html (#28259)
- FAIL [expected TIMEOUT] subtest: Autofocus elements in top-level browsing context's documents with "top" fragments should work. assert_not_equals: got disallowed value Element node <body>
  <div id="anchor1"></div>
  <input autofocus="">
  
  </b...
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Area element should support autofocus promise_test: Unhandled rejection with value: object "TypeError: w.document.querySelector(...) is null"
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
OK /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
- PASS [expected FAIL] subtest: Verifies that location navigations take precedence when following form submissions.
OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- FAIL [expected PASS] subtest: Check that rel=noopener with target=_self does a normal load this.openedWindow.findLink is not a function
PASS [expected CRASH] /streams/readable-streams/crashtests/strategy-worker-terminate.html (#30124)

mukilan · 2023-10-06T12:08:48Z

@delan I believe try jobs use the CI configuration from master and not the PR, so you might have to run the job on your fork for testing.

github-actions · 2023-10-06T12:23:08Z

✨ Try run (#6430688359) succeeded.

delan · 2023-10-09T09:25:58Z

Test builds for c5998d9:

servo-wpt-sync · 2023-10-11T08:31:09Z

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

servo-wpt-sync · 2023-10-11T08:32:10Z

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

delan · 2023-10-11T08:39:56Z

Test builds for 0974f6b:

servo-wpt-sync · 2023-10-11T09:00:37Z

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

servo-wpt-sync · 2023-10-11T09:54:51Z

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

delan · 2023-10-11T09:56:46Z

Test builds for 9225c74:

delan · 2023-10-18T10:50:57Z

Changing expectations for /css/css-color/currentcolor-003.html in layout 2013 from FAIL to CRASH, because it can’t be converted to a warning without modifying euclid, and it’s not clear to me how we can fix the underlying bug.

All other unexpected results should be covered by #30578 + #30590.

servo-wpt-sync · 2023-10-19T03:52:39Z

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

delan · 2023-10-19T03:58:31Z

Test builds for 6f1db35:

delan · 2023-10-25T04:52:52Z

Test builds for 41454f2:

servo-wpt-sync · 2023-10-25T04:52:57Z

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

servo-wpt-sync · 2023-10-25T05:03:04Z

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

components/embedder_traits/resources.rs

ports/servoshell/resources.rs

servo-wpt-sync · 2023-10-26T06:14:33Z

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

delan · 2023-10-26T06:16:20Z

Great catch @mukilan, that would have broken the nightly release build.

mukilan

Great work!

…leases (#30509)" This reverts commit a3d2f0c.

Run main and try jobs with debug assertions

977eeaf

delan requested review from mrobinson and mukilan October 6, 2023 09:48

delan mentioned this pull request Oct 6, 2023

build_canvas_background_display_list fails if :root is floating #30475

Closed

delan added 3 commits October 9, 2023 17:12

use single quotes in workflow expressions

e192d24

set force-debug-assertions in main.yml

b0fbb15

set force-debug-assertions as part of decision job

c5998d9

delan marked this pull request as draft October 11, 2023 08:07

delan added 4 commits October 11, 2023 16:09

fix typo in MachCommands.build

723ec29

fix more hardcoded profile names

8579754

merge from upstream/master

79f7ffb

fix tidy

0974f6b

split cargo_profile_option on windows

e021062

delan added 3 commits October 11, 2023 17:02

Fix running servoshell and unit tests through a symlink

a6e6a1a

rename steps to make them less confusing

3ed507d

fix more hardcoded cargo profile options

9225c74

fix missing inputs in linux-wpt and mac-wpt

13f6f4e

merge from upstream/master

6f1db35

delan force-pushed the try-with-debug-assertions branch from ccea918 to 6f1db35 Compare October 19, 2023 06:44

merge from upstream/master

b3b44ef

fix more references to {force,release-with}-debug-assertions

41454f2

mukilan reviewed Oct 26, 2023

View reviewed changes

components/embedder_traits/resources.rs Outdated Show resolved Hide resolved

delan requested a review from mukilan October 26, 2023 05:25

mukilan reviewed Oct 26, 2023

View reviewed changes

ports/servoshell/resources.rs Outdated Show resolved Hide resolved

fix local build failures under --profile production

f6bb635

delan requested a review from mukilan October 26, 2023 06:15

mukilan approved these changes Oct 26, 2023

View reviewed changes

delan enabled auto-merge October 26, 2023 06:24

delan added this pull request to the merge queue Oct 26, 2023

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 26, 2023

delan added this pull request to the merge queue Oct 26, 2023

Merged via the queue into servo:master with commit a3d2f0c Oct 26, 2023

delan deleted the try-with-debug-assertions branch October 26, 2023 09:43

mrobinson added a commit that referenced this pull request Oct 27, 2023

Revert "Enable debug assertions for all builds other than official re…

b5b5de9

…leases (#30509)" This reverts commit a3d2f0c.

mrobinson added a commit that referenced this pull request Oct 27, 2023

Revert "Enable debug assertions for all builds other than official re…

e68be1b

…leases (#30509)" This reverts commit a3d2f0c.

sagudev mentioned this pull request Oct 28, 2023

Support running custom wpt tests in wpt runs (and add suport for webgpu runs) #30627

Closed

3 tasks

mrobinson mentioned this pull request Mar 20, 2024

Run debug tests in CI #3450

Closed

delan mentioned this pull request Sep 17, 2024

Add a profiling build profile in Cargo #33432

Merged

2 tasks

Uh oh!

Conversation

delan commented Oct 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

delan commented Oct 6, 2023

Uh oh!

github-actions bot commented Oct 6, 2023

Uh oh!

github-actions bot commented Oct 6, 2023

Uh oh!

github-actions bot commented Oct 6, 2023

Uh oh!

mukilan commented Oct 6, 2023

Uh oh!

github-actions bot commented Oct 6, 2023

Uh oh!

delan commented Oct 9, 2023

Uh oh!

servo-wpt-sync commented Oct 11, 2023

Uh oh!

servo-wpt-sync commented Oct 11, 2023

Uh oh!

delan commented Oct 11, 2023

Uh oh!

servo-wpt-sync commented Oct 11, 2023

Uh oh!

servo-wpt-sync commented Oct 11, 2023

Uh oh!

delan commented Oct 11, 2023

Uh oh!

delan commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

servo-wpt-sync commented Oct 19, 2023

Uh oh!

delan commented Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

delan commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

servo-wpt-sync commented Oct 25, 2023

Uh oh!

servo-wpt-sync commented Oct 25, 2023

Uh oh!

Uh oh!

Uh oh!

servo-wpt-sync commented Oct 26, 2023

Uh oh!

delan commented Oct 26, 2023

Uh oh!

mukilan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

delan commented Oct 6, 2023 •

edited

Loading

delan commented Oct 18, 2023 •

edited

Loading

delan commented Oct 19, 2023 •

edited

Loading

delan commented Oct 25, 2023 •

edited

Loading