Skip to content

Upgrade the Rust toolchain to 'nightly-2023-02-01'#29318

Merged
bors-servo merged 1 commit intoservo:masterfrom
mukilan:upgrade-nightly-2023-02-01
Feb 2, 2023
Merged

Upgrade the Rust toolchain to 'nightly-2023-02-01'#29318
bors-servo merged 1 commit intoservo:masterfrom
mukilan:upgrade-nightly-2023-02-01

Conversation

@mukilan
Copy link
Member

@mukilan mukilan commented Feb 1, 2023

This change should address the failing nightly rustc test jobs

For reference, these are the relevant PRs in rustc that I could find.

Signed-off-by: Mukilan Thiyagarajan mukilanthiagarajan@gmail.com


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because there are existing unit tests for script_plugins that do pass.

Signed-off-by: Mukilan Thiyagarajan <mukilanthiagarajan@gmail.com>
@mukilan mukilan requested review from delan, jdm and mrobinson February 1, 2023 14:39
@mukilan
Copy link
Member Author

mukilan commented Feb 2, 2023

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 5738a16 with merge ef29d72...

bors-servo added a commit that referenced this pull request Feb 2, 2023
Upgrade the Rust toolchain to 'nightly-2023-02-01'

<!-- Please describe your changes on the following line: -->

This change should address the failing nightly [rustc test jobs](https://github.com/servo/servo/actions/workflows/nightly-rust.yml)

For reference, these are the [relevant](rust-lang/rust#107206) [PRs](rust-lang/rust#104170) in rustc that I could find.

Signed-off-by: Mukilan Thiyagarajan <mukilanthiagarajan@gmail.com>

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because there are existing unit tests for script_plugins that do pass.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github
State: approved= try=True

@delan
Copy link
Member

delan commented Feb 2, 2023

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 5738a16 has been approved by delan

@bors-servo
Copy link
Contributor

⌛ Testing commit 5738a16 with merge d581131...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github
Approved by: delan
Pushing d581131 to master...

@bors-servo bors-servo merged commit d581131 into servo:master Feb 2, 2023
@mukilan mukilan deleted the upgrade-nightly-2023-02-01 branch February 3, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants