CI: run WPT tests on macOS by delan · Pull Request #29201 · servo/servo

delan · 2023-01-04T13:07:33Z

This patch uncomments and fixes the mac-wpt job in the main workflow, with a few changes:

we downgrade python3 and pip3 to 3.9, because inspect.getargspec was removed in 3.11
- we should apparently move to inspect.getfullargspec
we download the real Servo artifact, rather than the fake Servo for testing

We also align the rest of the job (other than --timeout-multiplier) to be as close as possible to linux-wpt, based on the assumption that linux-wpt is more up to date. This includes:

setting strategy.fail-fast to false
adding a failure() condition to the “Archive logs” step
adding the chunk id to log filenames

There are some failing WPT tests, so for now the job is not required to succeed.

Example run: https://github.com/delan/servo/actions/runs/3837530905

~~./mach build -d does not report any errors~~
~~./mach test-tidy does not report any errors~~
These changes fix Run WPT tests (macOS) #28284 (GitHub issue number if applicable)

There are tests for these changes OR
These changes do not require tests because they affect the CI configuration

delan · 2023-01-04T13:12:42Z

oops, hit ctrl+enter by accident, but i’ve finished the description now!

jdm · 2023-01-04T15:06:24Z

@bors-servo try

bors-servo · 2023-01-04T15:25:05Z

⌛ Trying commit 55c4c7b with merge a991ee7...

CI: run WPT tests on macOS This patch uncomments and fixes the mac-wpt job in the main workflow, with a few changes: * we downgrade python3 and pip3 to 3.9, because inspect.getargspec was [removed in 3.11](https://docs.python.org/3/whatsnew/3.11.html#removed) * we should apparently move to [inspect.getfullargspec](https://docs.python.org/3/library/inspect.html#inspect.getfullargspec) * we download the real Servo artifact, rather than the fake Servo for testing We also align the rest of the job (other than `--timeout-multiplier`) to be as close as possible to linux-wpt, based on the assumption that linux-wpt is more up to date. This includes: * setting strategy.fail-fast to false * adding a failure() condition to the “Archive logs” step * adding the chunk id to log filenames There are some failing WPT tests, so for now the job is not required to succeed. Example run: <https://github.com/delan/servo/actions/runs/3837530905> --- - [ ] ~~`./mach build -d` does not report any errors~~ - [ ] ~~`./mach test-tidy` does not report any errors~~ - [x] These changes fix #28284 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [x] These changes do not require tests because they affect the CI configuration

andreubotella · 2023-01-04T18:35:55Z

we should apparently move to inspect.getfullargspec

For the record, mach only ever seems to use the args property of inspect.getargspec(), and that is unchanged in inspect.getfullargspec(). In fact, in Python 3.10 getargspec is implemented as a wrapper over getfullargspec that passes through some of its properties, including args. So updating mach to support Python 3.11 should be trivial.

bors-servo · 2023-01-04T21:22:49Z

💔 Test failed - checks-github

delan · 2023-01-05T00:31:31Z

@bors-servo try

bors-servo · 2023-01-05T00:31:33Z

@delan: 🔑 Insufficient privileges: not in try users

jdm · 2023-01-05T01:10:35Z

@bors-servo try

bors-servo · 2023-01-05T01:10:39Z

⌛ Trying commit 9f91b36 with merge 8c8fabd...

CI: run WPT tests on macOS This patch uncomments and fixes the mac-wpt job in the main workflow, with a few changes: * we downgrade python3 and pip3 to 3.9, because inspect.getargspec was [removed in 3.11](https://docs.python.org/3/whatsnew/3.11.html#removed) * we should apparently move to [inspect.getfullargspec](https://docs.python.org/3/library/inspect.html#inspect.getfullargspec) * we download the real Servo artifact, rather than the fake Servo for testing We also align the rest of the job (other than `--timeout-multiplier`) to be as close as possible to linux-wpt, based on the assumption that linux-wpt is more up to date. This includes: * setting strategy.fail-fast to false * adding a failure() condition to the “Archive logs” step * adding the chunk id to log filenames There are some failing WPT tests, so for now the job is not required to succeed. Example run: <https://github.com/delan/servo/actions/runs/3837530905> --- - [ ] ~~`./mach build -d` does not report any errors~~ - [ ] ~~`./mach test-tidy` does not report any errors~~ - [x] These changes fix #28284 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [x] These changes do not require tests because they affect the CI configuration

bors-servo · 2023-01-05T03:05:46Z

💔 Test failed - checks-github

delan · 2023-01-05T07:49:39Z

@bors-servo try

bors-servo · 2023-01-05T07:49:40Z

@delan: 🔑 Insufficient privileges: not in try users

delan · 2023-01-09T10:47:57Z

@bors-servo try

bors-servo · 2023-01-09T10:48:01Z

⌛ Trying commit 2d2668e with merge 1e1cef4...

CI: run WPT tests on macOS This patch uncomments and fixes the mac-wpt job in the main workflow, with a few changes: * we downgrade python3 and pip3 to 3.9, because inspect.getargspec was [removed in 3.11](https://docs.python.org/3/whatsnew/3.11.html#removed) * we should apparently move to [inspect.getfullargspec](https://docs.python.org/3/library/inspect.html#inspect.getfullargspec) * we download the real Servo artifact, rather than the fake Servo for testing We also align the rest of the job (other than `--timeout-multiplier`) to be as close as possible to linux-wpt, based on the assumption that linux-wpt is more up to date. This includes: * setting strategy.fail-fast to false * adding a failure() condition to the “Archive logs” step * adding the chunk id to log filenames There are some failing WPT tests, so for now the job is not required to succeed. Example run: <https://github.com/delan/servo/actions/runs/3837530905> --- - [ ] ~~`./mach build -d` does not report any errors~~ - [ ] ~~`./mach test-tidy` does not report any errors~~ - [x] These changes fix #28284 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [x] These changes do not require tests because they affect the CI configuration

bors-servo · 2023-01-09T12:38:58Z

💔 Test failed - checks-github

delan · 2023-01-09T12:46:41Z

@bors-servo retry

bors-servo · 2023-01-09T12:46:44Z

⌛ Trying commit 2d2668e with merge 21e40ad...

CI: run WPT tests on macOS This patch uncomments and fixes the mac-wpt job in the main workflow, with a few changes: * we downgrade python3 and pip3 to 3.9, because inspect.getargspec was [removed in 3.11](https://docs.python.org/3/whatsnew/3.11.html#removed) * we should apparently move to [inspect.getfullargspec](https://docs.python.org/3/library/inspect.html#inspect.getfullargspec) * we download the real Servo artifact, rather than the fake Servo for testing We also align the rest of the job (other than `--timeout-multiplier`) to be as close as possible to linux-wpt, based on the assumption that linux-wpt is more up to date. This includes: * setting strategy.fail-fast to false * adding a failure() condition to the “Archive logs” step * adding the chunk id to log filenames There are some failing WPT tests, so for now the job is not required to succeed. Example run: <https://github.com/delan/servo/actions/runs/3837530905> --- - [ ] ~~`./mach build -d` does not report any errors~~ - [ ] ~~`./mach test-tidy` does not report any errors~~ - [x] These changes fix #28284 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [x] These changes do not require tests because they affect the CI configuration

bors-servo · 2023-01-09T19:30:43Z

💔 Test failed - checks-github

delan · 2023-01-10T06:34:36Z

@bors-servo retry

bors-servo · 2023-01-10T06:34:40Z

⌛ Trying commit 2d2668e with merge e1dd70d...

CI: run WPT tests on macOS This patch uncomments and fixes the mac-wpt job in the main workflow, with a few changes: * we downgrade python3 and pip3 to 3.9, because inspect.getargspec was [removed in 3.11](https://docs.python.org/3/whatsnew/3.11.html#removed) * we should apparently move to [inspect.getfullargspec](https://docs.python.org/3/library/inspect.html#inspect.getfullargspec) * we download the real Servo artifact, rather than the fake Servo for testing We also align the rest of the job (other than `--timeout-multiplier`) to be as close as possible to linux-wpt, based on the assumption that linux-wpt is more up to date. This includes: * setting strategy.fail-fast to false * adding a failure() condition to the “Archive logs” step * adding the chunk id to log filenames There are some failing WPT tests, so for now the job is not required to succeed. Example run: <https://github.com/delan/servo/actions/runs/3837530905> --- - [ ] ~~`./mach build -d` does not report any errors~~ - [ ] ~~`./mach test-tidy` does not report any errors~~ - [x] These changes fix #28284 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [x] These changes do not require tests because they affect the CI configuration

bors-servo · 2023-01-10T08:30:54Z

💔 Test failed - checks-github

CYBAI · 2023-01-11T02:44:41Z

@bors-servo retry

bors-servo · 2023-01-11T02:44:45Z

⌛ Trying commit 2d2668e with merge a694471...

CI: run WPT tests on macOS This patch uncomments and fixes the mac-wpt job in the main workflow, with a few changes: * we downgrade python3 and pip3 to 3.9, because inspect.getargspec was [removed in 3.11](https://docs.python.org/3/whatsnew/3.11.html#removed) * we should apparently move to [inspect.getfullargspec](https://docs.python.org/3/library/inspect.html#inspect.getfullargspec) * we download the real Servo artifact, rather than the fake Servo for testing We also align the rest of the job (other than `--timeout-multiplier`) to be as close as possible to linux-wpt, based on the assumption that linux-wpt is more up to date. This includes: * setting strategy.fail-fast to false * adding a failure() condition to the “Archive logs” step * adding the chunk id to log filenames There are some failing WPT tests, so for now the job is not required to succeed. Example run: <https://github.com/delan/servo/actions/runs/3837530905> --- - [ ] ~~`./mach build -d` does not report any errors~~ - [ ] ~~`./mach test-tidy` does not report any errors~~ - [x] These changes fix #28284 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [x] These changes do not require tests because they affect the CI configuration

bors-servo · 2023-01-11T07:21:32Z

☀️ Test successful - checks-github
State: approved= try=True

delan · 2023-01-11T14:24:59Z

@bors-servo r=jdm

bors-servo · 2023-01-11T14:25:00Z

📌 Commit 2d2668e has been approved by jdm

bors-servo · 2023-01-11T15:55:16Z

⌛ Testing commit 2d2668e with merge 17a4590...

CI: run WPT tests on macOS This patch uncomments and fixes the mac-wpt job in the main workflow, with a few changes: * we downgrade python3 and pip3 to 3.9, because inspect.getargspec was [removed in 3.11](https://docs.python.org/3/whatsnew/3.11.html#removed) * we should apparently move to [inspect.getfullargspec](https://docs.python.org/3/library/inspect.html#inspect.getfullargspec) * we download the real Servo artifact, rather than the fake Servo for testing We also align the rest of the job (other than `--timeout-multiplier`) to be as close as possible to linux-wpt, based on the assumption that linux-wpt is more up to date. This includes: * setting strategy.fail-fast to false * adding a failure() condition to the “Archive logs” step * adding the chunk id to log filenames There are some failing WPT tests, so for now the job is not required to succeed. Example run: <https://github.com/delan/servo/actions/runs/3837530905> --- - [ ] ~~`./mach build -d` does not report any errors~~ - [ ] ~~`./mach test-tidy` does not report any errors~~ - [x] These changes fix #28284 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [x] These changes do not require tests because they affect the CI configuration

bors-servo · 2023-01-11T18:14:33Z

💔 Test failed - checks-github

jdm · 2023-01-12T01:32:12Z

Yikes.

delan · 2023-01-12T13:23:44Z

@bors-servo retry

bors-servo · 2023-01-12T13:23:48Z

⌛ Testing commit 2d2668e with merge 806db67...

bors-servo · 2023-01-12T15:14:26Z

💔 Test failed - checks-github

bors-servo · 2023-01-13T12:52:00Z

☀️ Test successful - checks-github
Approved by: jdm
Pushing 806db67 to master...

CI: disable mac-wpt job in main workflow In theory, the new mac-wpt jobs added in #29201 are harmless since they aren’t required for the main workflow to succeed, but in practice, the runners are so slow to assign and run that they break the build. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [x] These changes do not require tests because they affect the CI configuration

delan added 6 commits January 4, 2023 20:58

CI: uncomment mac-wpt job in main workflow

a1b5a73

CI: bump mac-wpt job from macos-10.12 to macos-12

1b629c6

CI: fix python error in mac-wpt job

a24b12f

CI: align (most) of mac-wpt job with linux-wpt

83c86a5

CI: revert temporary changes for quick testing

8c18196

CI: don’t require mac-wpt to succeed

55c4c7b

CI: enable mac-wpt chunks 2 through 20

9f91b36

delan mentioned this pull request Jan 5, 2023

Add try users @delan + @Loirooriol + @mrego + @mrobinson servo/saltfs#1033

Merged

CI: fix nproc command not found on macOS

2d2668e

This was referenced Jan 9, 2023

Intermittent failure in /css/css-color/animation/opacity-animation-ending-correctly-001.html #29215

Closed

Intermittent failure in /css/css-color/animation/opacity-animation-ending-correctly-002.html #29216

Closed

delan mentioned this pull request Jan 10, 2023

Intermittent failure in /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected.html #29224

Closed

delan requested a review from jdm January 11, 2023 09:44

jdm approved these changes Jan 11, 2023

View reviewed changes

bors-servo merged commit 806db67 into servo:master Jan 13, 2023

delan deleted the ci-mac-wpt branch January 13, 2023 13:25

delan mentioned this pull request Jan 16, 2023

CI: disable mac-wpt job in main workflow #29244

Merged

5 tasks

Uh oh!

Conversation

delan commented Jan 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

delan commented Jan 4, 2023

Uh oh!

jdm commented Jan 4, 2023

Uh oh!

bors-servo commented Jan 4, 2023

Uh oh!

andreubotella commented Jan 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors-servo commented Jan 4, 2023

Uh oh!

delan commented Jan 5, 2023

Uh oh!

bors-servo commented Jan 5, 2023

Uh oh!

jdm commented Jan 5, 2023

Uh oh!

bors-servo commented Jan 5, 2023

Uh oh!

bors-servo commented Jan 5, 2023

Uh oh!

delan commented Jan 5, 2023

Uh oh!

bors-servo commented Jan 5, 2023

Uh oh!

delan commented Jan 9, 2023

Uh oh!

bors-servo commented Jan 9, 2023

Uh oh!

bors-servo commented Jan 9, 2023

Uh oh!

delan commented Jan 9, 2023

Uh oh!

bors-servo commented Jan 9, 2023

Uh oh!

bors-servo commented Jan 9, 2023

Uh oh!

delan commented Jan 10, 2023

Uh oh!

bors-servo commented Jan 10, 2023

Uh oh!

bors-servo commented Jan 10, 2023

Uh oh!

CYBAI commented Jan 11, 2023

Uh oh!

bors-servo commented Jan 11, 2023

Uh oh!

bors-servo commented Jan 11, 2023

Uh oh!

delan commented Jan 11, 2023

Uh oh!

bors-servo commented Jan 11, 2023

Uh oh!

bors-servo commented Jan 11, 2023

Uh oh!

bors-servo commented Jan 11, 2023

Uh oh!

jdm commented Jan 12, 2023

Uh oh!

delan commented Jan 12, 2023

Uh oh!

bors-servo commented Jan 12, 2023

Uh oh!

bors-servo commented Jan 12, 2023

Uh oh!

bors-servo commented Jan 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

delan commented Jan 4, 2023 •

edited

Loading

andreubotella commented Jan 4, 2023 •

edited

Loading