CI: remove branch check steps that don’t actually do anything#29198
Merged
bors-servo merged 1 commit intoservo:masterfrom Jan 11, 2023
Merged
CI: remove branch check steps that don’t actually do anything#29198bors-servo merged 1 commit intoservo:masterfrom
bors-servo merged 1 commit intoservo:masterfrom
Conversation
Member
|
Hmm, interesting. The intent behind these checks was to support things like |
Member
|
That being said, it doesn't need to happen in this PR, and we can remove things that are not actually making any difference. |
Contributor
|
📌 Commit 8663757 has been approved by |
Member
Author
|
Thanks for the context! I have some ideas for how to solve that, but yeah, let’s do that in a second patch. |
Contributor
bors-servo
added a commit
that referenced
this pull request
Jan 4, 2023
CI: remove branch check steps that don’t actually do anything f165e17 (#28778) adds a step to each job of the main build that ostensibly bails out of the job, if the context branch is not `auto` or one of the `try` branches relevant for that platform. But a step that runs `exit 0` doesn’t really have any effect. Since the main workflow already has `branches` limited to `auto` and the `try` branches, we can safely remove those steps without worrying about the main build running on dependabot branches etc. For example: * [dependabot/cargo/nom-7.1.2](https://github.com/servo/servo/actions?query=branch%3Adependabot%2Fcargo%2Fnom-7.1.2) only has a run for the pull request workflow * [this test build](https://github.com/delan/servo/actions/runs/3830596812/jobs/6518672884) shows that even if the branch check fails, the build continues --- - [ ] ~~`./mach build -d` does not report any errors~~ - [ ] ~~`./mach test-tidy` does not report any errors~~ - [ ] ~~These changes fix #___ (GitHub issue number if applicable)~~ <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they affect the CI configuration
Contributor
|
💔 Test failed - checks-github |
Member
|
@bors-servo retry |
Contributor
bors-servo
added a commit
that referenced
this pull request
Jan 5, 2023
CI: remove branch check steps that don’t actually do anything f165e17 (#28778) adds a step to each job of the main build that ostensibly bails out of the job, if the context branch is not `auto` or one of the `try` branches relevant for that platform. But a step that runs `exit 0` doesn’t really have any effect. Since the main workflow already has `branches` limited to `auto` and the `try` branches, we can safely remove those steps without worrying about the main build running on dependabot branches etc. For example: * [dependabot/cargo/nom-7.1.2](https://github.com/servo/servo/actions?query=branch%3Adependabot%2Fcargo%2Fnom-7.1.2) only has a run for the pull request workflow * [this test build](https://github.com/delan/servo/actions/runs/3830596812/jobs/6518672884) shows that even if the branch check fails, the build continues --- - [ ] ~~`./mach build -d` does not report any errors~~ - [ ] ~~`./mach test-tidy` does not report any errors~~ - [ ] ~~These changes fix #___ (GitHub issue number if applicable)~~ <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they affect the CI configuration
Contributor
|
💔 Test failed - checks-github |
Member
Author
|
@bors-servo retry |
Contributor
|
@delan: 🔑 Insufficient privileges: not in try users |
Member
|
I've deployed the saltfs changes; you shouldn't have further problems issuing homu commands. |
Member
|
@bors-servo retry |
Contributor
bors-servo
added a commit
that referenced
this pull request
Jan 6, 2023
CI: remove branch check steps that don’t actually do anything f165e17 (#28778) adds a step to each job of the main build that ostensibly bails out of the job, if the context branch is not `auto` or one of the `try` branches relevant for that platform. But a step that runs `exit 0` doesn’t really have any effect. Since the main workflow already has `branches` limited to `auto` and the `try` branches, we can safely remove those steps without worrying about the main build running on dependabot branches etc. For example: * [dependabot/cargo/nom-7.1.2](https://github.com/servo/servo/actions?query=branch%3Adependabot%2Fcargo%2Fnom-7.1.2) only has a run for the pull request workflow * [this test build](https://github.com/delan/servo/actions/runs/3830596812/jobs/6518672884) shows that even if the branch check fails, the build continues --- - [ ] ~~`./mach build -d` does not report any errors~~ - [ ] ~~`./mach test-tidy` does not report any errors~~ - [ ] ~~These changes fix #___ (GitHub issue number if applicable)~~ <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they affect the CI configuration
Contributor
|
💔 Test failed - checks-github |
Member
Author
|
@bors-servo retry |
Contributor
bors-servo
added a commit
that referenced
this pull request
Jan 9, 2023
CI: remove branch check steps that don’t actually do anything f165e17 (#28778) adds a step to each job of the main build that ostensibly bails out of the job, if the context branch is not `auto` or one of the `try` branches relevant for that platform. But a step that runs `exit 0` doesn’t really have any effect. Since the main workflow already has `branches` limited to `auto` and the `try` branches, we can safely remove those steps without worrying about the main build running on dependabot branches etc. For example: * [dependabot/cargo/nom-7.1.2](https://github.com/servo/servo/actions?query=branch%3Adependabot%2Fcargo%2Fnom-7.1.2) only has a run for the pull request workflow * [this test build](https://github.com/delan/servo/actions/runs/3830596812/jobs/6518672884) shows that even if the branch check fails, the build continues --- - [ ] ~~`./mach build -d` does not report any errors~~ - [ ] ~~`./mach test-tidy` does not report any errors~~ - [ ] ~~These changes fix #___ (GitHub issue number if applicable)~~ <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they affect the CI configuration
Contributor
|
💔 Test failed - checks-github |
Member
Author
|
@bors-servo retry |
Contributor
bors-servo
added a commit
that referenced
this pull request
Jan 10, 2023
CI: remove branch check steps that don’t actually do anything f165e17 (#28778) adds a step to each job of the main build that ostensibly bails out of the job, if the context branch is not `auto` or one of the `try` branches relevant for that platform. But a step that runs `exit 0` doesn’t really have any effect. Since the main workflow already has `branches` limited to `auto` and the `try` branches, we can safely remove those steps without worrying about the main build running on dependabot branches etc. For example: * [dependabot/cargo/nom-7.1.2](https://github.com/servo/servo/actions?query=branch%3Adependabot%2Fcargo%2Fnom-7.1.2) only has a run for the pull request workflow * [this test build](https://github.com/delan/servo/actions/runs/3830596812/jobs/6518672884) shows that even if the branch check fails, the build continues --- - [ ] ~~`./mach build -d` does not report any errors~~ - [ ] ~~`./mach test-tidy` does not report any errors~~ - [ ] ~~These changes fix #___ (GitHub issue number if applicable)~~ <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they affect the CI configuration
Contributor
|
💔 Test failed - checks-github |
Member
Author
|
@bors-servo retry |
Contributor
bors-servo
added a commit
that referenced
this pull request
Jan 10, 2023
CI: remove branch check steps that don’t actually do anything f165e17 (#28778) adds a step to each job of the main build that ostensibly bails out of the job, if the context branch is not `auto` or one of the `try` branches relevant for that platform. But a step that runs `exit 0` doesn’t really have any effect. Since the main workflow already has `branches` limited to `auto` and the `try` branches, we can safely remove those steps without worrying about the main build running on dependabot branches etc. For example: * [dependabot/cargo/nom-7.1.2](https://github.com/servo/servo/actions?query=branch%3Adependabot%2Fcargo%2Fnom-7.1.2) only has a run for the pull request workflow * [this test build](https://github.com/delan/servo/actions/runs/3830596812/jobs/6518672884) shows that even if the branch check fails, the build continues --- - [ ] ~~`./mach build -d` does not report any errors~~ - [ ] ~~`./mach test-tidy` does not report any errors~~ - [ ] ~~These changes fix #___ (GitHub issue number if applicable)~~ <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they affect the CI configuration
Contributor
|
💔 Test failed - checks-github |
Contributor
Contributor
|
☀️ Test successful - checks-github |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f165e17 (#28778) adds a step to each job of the main build that ostensibly bails out of the job, if the context branch is not
autoor one of thetrybranches relevant for that platform. But a step that runsexit 0doesn’t really have any effect.Since the main workflow already has
brancheslimited toautoand thetrybranches, we can safely remove those steps without worrying about the main build running on dependabot branches etc. For example:./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThese changes fix #___ (GitHub issue number if applicable)