Skip to content

Some Cargo.toml cleanups#26319

Merged
bors-servo merged 1 commit intoservo:masterfrom
atouchet:cargo
Apr 26, 2020
Merged

Some Cargo.toml cleanups#26319
bors-servo merged 1 commit intoservo:masterfrom
atouchet:cargo

Conversation

@atouchet
Copy link
Contributor

Some Cargo.toml cleanups. Adapted from #26024.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/Cargo.toml, components/script/Cargo.toml
  • @cbrewster: components/constellation/Cargo.toml
  • @KiChjang: components/script/Cargo.toml

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 25, 2020
@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@jdm
Copy link
Member

jdm commented Apr 25, 2020

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

📌 Commit b5a3f01 has been approved by jdm

@highfive highfive assigned jdm and unassigned nox Apr 25, 2020
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 25, 2020
@bors-servo
Copy link
Contributor

⌛ Testing commit b5a3f01 with merge bcdc555...

bors-servo added a commit that referenced this pull request Apr 25, 2020
Some Cargo.toml cleanups

<!-- Please describe your changes on the following line: -->
Some Cargo.toml cleanups. Adapted from #26024.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 25, 2020
@jdm
Copy link
Member

jdm commented Apr 25, 2020

@bors-servo
Copy link
Contributor

⌛ Testing commit b5a3f01 with merge 83771d0...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 25, 2020
@bors-servo
Copy link
Contributor

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 83771d0 to master...

@bors-servo bors-servo merged commit 83771d0 into servo:master Apr 26, 2020
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 26, 2020
@atouchet atouchet deleted the cargo branch April 26, 2020 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants