Skip to content

Extract IPC out of webrender#24875

Merged
bors-servo merged 1 commit intoservo:masterfrom
jdm:wr-no-ipc
Nov 28, 2019
Merged

Extract IPC out of webrender#24875
bors-servo merged 1 commit intoservo:masterfrom
jdm:wr-no-ipc

Conversation

@jdm
Copy link
Member

@jdm jdm commented Nov 26, 2019 •
edited
Loading

Fixes #20172. Fixes #13480.

@highfive
Copy link

highfive commented Nov 26, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/window.rs, components/script/dom/htmlmediaelement.rs, components/script/dom/bindings/trace.rs, components/script/Cargo.toml, components/constellation/pipeline.rs and 3 more
  • @cbrewster: components/constellation/pipeline.rs, components/constellation/Cargo.toml, components/constellation/constellation.rs
  • @KiChjang: components/net/image_cache.rs, components/script/dom/window.rs, components/script_traits/lib.rs, components/net_traits/lib.rs, components/script/dom/htmlmediaelement.rs and 7 more
  • @emilio: components/layout/Cargo.toml

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 26, 2019
@highfive
Copy link

highfive commented Nov 26, 2019

warning Warning warning

  • These commits modify net, layout, gfx, and script code, but no tests are modified. Please consider adding a test!

@jdm jdm unassigned ferjm Nov 26, 2019
@jdm jdm removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 26, 2019
@jdm
Copy link
Member Author

jdm commented Nov 26, 2019

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2019

⌛ Trying commit bb74a75 with merge 1e18c57...

bors-servo pushed a commit that referenced this pull request Nov 26, 2019
Auto merge of #24875 - jdm:wr-no-ipc, r=<try>
1e18c57 
Extract IPC out of webrender
@jdm
Copy link
Member Author

jdm commented Nov 26, 2019 •
edited
Loading

Note to self:

@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2019

💔 Test failed - status-taskcluster

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Nov 26, 2019
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 26, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2019

☔ The latest upstream changes (presumably #24758) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Nov 26, 2019
@jdm jdm force-pushed the wr-no-ipc branch 3 times, most recently from ad54500 to 8816ccb Compare November 26, 2019 22:28
@jdm jdm marked this pull request as ready for review November 26, 2019 22:29
@jdm jdm removed the S-needs-rebase There are merge conflict errors. label Nov 26, 2019
@jdm
Copy link
Member Author

jdm commented Nov 26, 2019

r? @asajeffrey

I realized that this can land separately from https://github.com/jdm/webrender/tree/no-ipc; all we have to do is stop using the optional ipc feature from WebRender.

@jdm jdm force-pushed the wr-no-ipc branch 2 times, most recently from 14e1afc to 05afb9b Compare November 26, 2019 23:33
@asajeffrey
Copy link
Contributor

asajeffrey commented Nov 27, 2019

Ooh this looks pretty good. I'll have a proper look later today.

@jdm jdm mentioned this pull request Nov 27, 2019
Merged
asajeffrey
asajeffrey approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@asajeffrey asajeffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor nits. Lots of new tests that pass yay! One new test that fails, do you know why?

bors-servo pushed a commit that referenced this pull request Nov 27, 2019
Auto merge of #24875 - jdm:wr-no-ipc, r=asajeffrey
c6610e4 
Extract IPC out of webrender

Fixes #20172. Fixes #13480.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2019

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 27, 2019
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 27, 2019
@jdm
Copy link
Member Author

jdm commented Nov 27, 2019

@bors-servo r=asajeffrey

@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2019

📌 Commit e5d6961 has been approved by asajeffrey

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 27, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2019

⌛ Testing commit e5d6961 with merge a4b62f3...

bors-servo pushed a commit that referenced this pull request Nov 27, 2019
Auto merge of #24875 - jdm:wr-no-ipc, r=asajeffrey
a4b62f3 
Extract IPC out of webrender

Fixes #20172. Fixes #13480.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2019

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 27, 2019
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 28, 2019
@jdm
Copy link
Member Author

jdm commented Nov 28, 2019

@bors-servo r=asajeffrey

@bors-servo
Copy link
Contributor

bors-servo commented Nov 28, 2019

📌 Commit 564c16d has been approved by asajeffrey

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 28, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Nov 28, 2019

⌛ Testing commit 564c16d with merge 5f1681a...

bors-servo pushed a commit that referenced this pull request Nov 28, 2019
Auto merge of #24875 - jdm:wr-no-ipc, r=asajeffrey
5f1681a 
Extract IPC out of webrender

Fixes #20172. Fixes #13480.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 28, 2019

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing 5f1681a to master...

@bors-servo bors-servo merged commit 564c16d into servo:master Nov 28, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 28, 2019
@bors-servo bors-servo mentioned this pull request Nov 28, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment