Skip to content

Use #![register_tool] instead of Registry::register_attribute #24750

Merged
bors-servo merged 2 commits intomasterfrom
register-tool
Nov 16, 2019
Merged

Use #![register_tool] instead of Registry::register_attribute #24750
bors-servo merged 2 commits intomasterfrom
register-tool

Conversation

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Nov 15, 2019

@highfive
Copy link

highfive commented Nov 15, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglvertexarrayobjectoes.rs, components/script/canvas_state.rs, components/script/dom/webglframebuffer.rs, components/script/dom/range.rs, components/script/dom/customelementregistry.rs and 36 more
  • @KiChjang: components/script/dom/webglvertexarrayobjectoes.rs, components/script/canvas_state.rs, components/script/dom/webglframebuffer.rs, components/script/dom/range.rs, components/script/dom/customelementregistry.rs and 36 more

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 15, 2019
@SimonSapin SimonSapin mentioned this pull request Nov 15, 2019
Merged
5 tasks
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 15, 2019

This requires a compiler upgrade which was blocked by #24684, but is not longer blocked since rust-lang/rust#66378.

@jdm
Copy link
Member

jdm commented Nov 15, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

📌 Commit 6df9460 has been approved by jdm

@highfive highfive assigned jdm and unassigned asajeffrey Nov 15, 2019
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 15, 2019
@jdm
Copy link
Member

jdm commented Nov 15, 2019

@bors-servo p=1

@jdm
Copy link
Member

jdm commented Nov 15, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

📌 Commit bea7395 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

⌛ Testing commit bea7395 with merge 03d632f...

bors-servo pushed a commit that referenced this pull request Nov 15, 2019
Auto merge of #24750 - servo:register-tool, r=jdm
03d632f 
Use `#![register_tool]` instead of `Registry::register_attribute`

CC rust-lang/rust#66344, rust-lang/rust#66079
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 15, 2019

@bors-servo treeclosed=100

Deploying servo/taskcluster-config#4

@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 15, 2019
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 15, 2019

@bors-servo retry treeclosed-

@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

💣 Failed to start rebuilding: 405 Not Allowed

@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

⌛ Testing commit bea7395 with merge d92f705...

bors-servo pushed a commit that referenced this pull request Nov 15, 2019
Auto merge of #24750 - servo:register-tool, r=jdm
d92f705 
Use `#![register_tool]` instead of `Registry::register_attribute`

CC rust-lang/rust#66344, rust-lang/rust#66079
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 15, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 15, 2019
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 15, 2019

@bors-servo retry

  ▶ FAIL [expected PASS] /css/CSS2/tables/border-collapse-dynamic-cell-001.xht
  └   → /css/CSS2/tables/border-collapse-dynamic-cell-001.xht 9565d734a7fc1b3d50a261d4a24bd5a950ac2f7d
/css/CSS2/tables/border-collapse-dynamic-cell-001-ref.xht 54a9df64f1476dd12020019d7cf22ac34d727bc0

@jdm
Copy link
Member

jdm commented Nov 15, 2019

That's #24726.

@SimonSapin SimonSapin mentioned this pull request Nov 15, 2019
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

⚡ Previous build results for linux-rel-css, status-taskcluster are reusable. Rebuilding only linux-rel-wpt...

@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing d92f705 to master...

@bors-servo bors-servo merged commit bea7395 into master Nov 16, 2019
@bors-servo bors-servo deleted the register-tool branch November 16, 2019 00:45
@bors-servo bors-servo mentioned this pull request Nov 16, 2019
Closed
@saschanaz saschanaz mentioned this pull request Nov 16, 2019
Closed
@Manishearth Manishearth mentioned this pull request Nov 18, 2019
Closed
@SimonSapin SimonSapin mentioned this pull request Nov 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdm jdm

Labels

S-tests-failed The changes caused existing tests to fail.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SimonSapin @highfive @jdm @bors-servo @asajeffrey