Force pkg-config to find installed homebrew packages.#24688
Closed
Force pkg-config to find installed homebrew packages.#24688
Conversation
Member
Author
|
r? @SimonSapin |
Member
|
Should we move to Homebrew in |
Member
Author
|
I would prefer landing this first and dealing with changing everything later :) |
Member
|
Let’s try this on mac9 (with 3a81839 + servo/taskcluster-config@725d55c) @bors-servo try=mac |
bors-servo
pushed a commit
that referenced
this pull request
Nov 9, 2019
Force pkg-config to find installed homebrew packages. This is needed to add mac9 to the pool of workers, since newer installations of pkg-config default to /usr/local instead of the homebrew prefix.
Contributor
Contributor
|
💔 Test failed - status-taskcluster |
Member
|
Same as before:
|
Member
Note to remove or revert 3a81839 from this PR’s branch before landing. |
bors-servo
pushed a commit
that referenced
this pull request
Nov 16, 2019
Use an already-installed Homebrew at /usr/local This requires servo/taskcluster-config#4 to be deployed. Having the standard location helps `pkg-config` (CC #24688), and allows installing pre-compiled pakcages (which is much faster than compiling from source).
bors-servo
pushed a commit
that referenced
this pull request
Nov 16, 2019
Use an already-installed Homebrew at /usr/local This requires servo/taskcluster-config#4 to be deployed. Having the standard location helps `pkg-config` (CC #24688), and allows installing pre-compiled pakcages (which is much faster than compiling from source).
bors-servo
pushed a commit
that referenced
this pull request
Nov 17, 2019
Use an already-installed Homebrew at /usr/local This requires servo/taskcluster-config#4 to be deployed. Having the standard location helps `pkg-config` (CC #24688), and allows installing pre-compiled pakcages (which is much faster than compiling from source).
bors-servo
pushed a commit
that referenced
this pull request
Nov 17, 2019
Use an already-installed Homebrew at /usr/local This requires servo/taskcluster-config#4 to be deployed. Having the standard location helps `pkg-config` (CC #24688), and allows installing pre-compiled pakcages (which is much faster than compiling from source).
bors-servo
pushed a commit
that referenced
this pull request
Nov 17, 2019
Use an already-installed Homebrew at /usr/local This requires servo/taskcluster-config#4 to be deployed. Having the standard location helps `pkg-config` (CC #24688), and allows installing pre-compiled pakcages (which is much faster than compiling from source).
bors-servo
pushed a commit
that referenced
this pull request
Nov 17, 2019
Use an already-installed Homebrew at /usr/local This requires servo/taskcluster-config#4 to be deployed. Having the standard location helps `pkg-config` (CC #24688), and allows installing pre-compiled pakcages (which is much faster than compiling from source).
bors-servo
pushed a commit
that referenced
this pull request
Nov 17, 2019
Use an already-installed Homebrew at /usr/local This requires servo/taskcluster-config#4 to be deployed. Having the standard location helps `pkg-config` (CC #24688), and allows installing pre-compiled pakcages (which is much faster than compiling from source).
bors-servo
pushed a commit
that referenced
this pull request
Nov 17, 2019
Use an already-installed Homebrew at /usr/local This requires servo/taskcluster-config#4 to be deployed. Having the standard location helps `pkg-config` (CC #24688), and allows installing pre-compiled pakcages (which is much faster than compiling from source).
bors-servo
pushed a commit
that referenced
this pull request
Nov 17, 2019
Use an already-installed Homebrew at /usr/local This requires servo/taskcluster-config#4 to be deployed. Having the standard location helps `pkg-config` (CC #24688), and allows installing pre-compiled pakcages (which is much faster than compiling from source).
Contributor
|
☔ The latest upstream changes (presumably #24753) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
#24688 makes this unnecessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to add mac9 to the pool of workers, since newer installations of pkg-config default to /usr/local instead of the homebrew prefix.