Skip to content

Upgrade to rustc 1.40.0-nightly (246be7e1a 2019-10-25)#24557

Merged
bors-servo merged 3 commits intomasterfrom
rustup
Oct 28, 2019
Merged

Upgrade to rustc 1.40.0-nightly (246be7e1a 2019-10-25)#24557
bors-servo merged 3 commits intomasterfrom
rustup

Conversation

@SimonSapin
Copy link
Member

No description provided.

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/lib.rs, components/script/init.rs
  • @KiChjang: components/script/lib.rs, components/script/init.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 26, 2019
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!

@jdm
Copy link
Member

jdm commented Oct 26, 2019

script_plugins isn't building correctly.

@SimonSapin
Copy link
Member Author

This is because compiler crates used by compiler plugins have been moved out of the rust-std component in rustup and into a new rustc-dev component. I’ve pushed another commit to install that.

@jdm
Copy link
Member

jdm commented Oct 27, 2019

The scrupt_plugins for the taskcluster tidy/unit job is still broken.

@SimonSapin
Copy link
Member Author

Ah, pre-review testing of PRs was yet another code path in decision_task.py. That’s a bit unfortunate.

@jdm
Copy link
Member

jdm commented Oct 28, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 6ba0fab has been approved by jdm

@highfive highfive assigned jdm and unassigned ferjm Oct 28, 2019
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 28, 2019
bors-servo pushed a commit that referenced this pull request Oct 28, 2019
Upgrade to rustc 1.40.0-nightly (246be7e1a 2019-10-25)
@bors-servo
Copy link
Contributor

⌛ Testing commit 6ba0fab with merge bb2c03a...

@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing bb2c03a to master...

@bors-servo bors-servo merged commit 6ba0fab into master Oct 28, 2019
@bors-servo bors-servo deleted the rustup branch October 28, 2019 18:16
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants