Android life cycle improvements and Gradle integration by MortimerGoro · Pull Request #15773 · servo/servo

MortimerGoro · 2017-02-28T20:48:43Z

This PR includes Android life cycle Improvements and Gradle integration for android packaging.

Android life cycle improvements are implemented in both the new MainActivity and native code in this related PR: servo/glutin#117

Properly handle the life cycle of the Android Activity: manage EGLContext lost & restore, and animation loop pause/resume when the app goes to background/foreground or orientation changes. In the current upstream Servo crashes when the app goes to background, activity stops or changes orientation
Handle event loop awake for Servo Animation loop
Handle screen resize & orientation events
Implement new keep_screen_on preference which keeps Android device's screen from ever going to sleep: very useful for games or WebVR
Implement a full screen mode enabled by preference: very useful for games or WebVR
Implement new shell.native-orientation preference which allows to lock the Activity to a specific orientation
Automatically sync new android assets to sdcard when the Android version code is changed. In the current upstream only the existence of the folder is check but resources are not updated

ofscreen_gl_context is updated to fix this: servo/surfman#83

This PR integrates Gradle build system for android packaging. Most of the code is implemented in this build.gradle . We can get rid of build-apk and manual jar dependency copying in the package_commands.py. The correct version of gradle is automatically downloaded using the gradlew wrapper.

Some improvements:

Allows to include more complex android dependencies/SDKs like AARs, manifest auto-merging and more.
Improved packaging process: The gradle project is always in the same folder, it uses relative paths for everything (assets, native libraries) and outputs the apk into the correct target folder in servo. In the current upstream, ant/python build system copies the manifest, project, resources and jars each time so you end with multiple copies of the same files.
Improved dependency declaration. We do not have to manually copy jar dependencies in the python script anymore. The gradle build scripts itself is able to search for the dependencies in the correct servo target folder.
Supports packaging apks with different architectures: armeabi, armeabi-v7a, aarch64. We still need to fix some native servo compilation issues with armeabi-v7a, aarch64 due to dependencies which use make. I'll push this changes in a separate PR of the python build files but the gradle file is already ready to handle that.
We can easily create product flavors for different versions of Servo. For example a default browser, a WebVR browser with additional dependencies or a Servo android Webview component
Fixes minor.major.52 build error when blurdroid cargo dependency is compiled using java8 (the default in new Linux machines). The gradle build file enables the new Jack compiler which supports Java8 dependencies.
The project can be opened with Android Studio and run the brand new GPU debugger on any Android phone. I'll add some docs in the Wiki about this.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix Runtime problems on Android #14568 (github issue number if applicable).

There are tests for these changes OR
These changes do not require tests because _____

This change is

highfive · 2017-02-28T20:48:47Z

Heads up! This PR modifies the following files:

@wafflespeanut: python/servo/package_commands.py

larsbergstrom · 2017-02-28T21:22:27Z

Awesome work, @MortimerGoro!

@fabricedesre Would you mind doing the initial review of this? :-)

fabricedesre · 2017-02-28T21:43:59Z

@larsbergstrom sure, will do.

fabricedesre

Thanks for doing that, this is super nice!
I left mostly nits, except the change to a minimum sdk version that will simplify the code.

fabricedesre · 2017-03-02T17:58:45Z

support/android/apk/app/build.gradle

+
+    defaultConfig {
+        applicationId "com.mozilla.servo"
+        minSdkVersion 18


There is little value supporting such an old version (This is Jelly Bean!). Let's move to 21 instead (Lollipop).

I agree that setting target 21 would simplify parts of the code (is the minimum api level for native arm64 builds too). But Jelly bean + KitKat still has around 35-40% market share (https://developer.android.com/about/dashboards/index.html). What do you think about this @larsbergstrom ?

Older devices are still widely used (think developing countries and regional differences), and several of our test devices also run Android 4.4. I'd like API 18 support too.

fabricedesre · 2017-03-02T18:01:08Z

support/android/apk/app/build.gradle

+    // For each dependency call the proper compile command and set the correct dependency path
+    def list = ['arm', 'armv7', 'arm64', 'x86']
+    for (arch in list) {
+        for (int i = 0; i <= 1; ++i) {


can't we do something like for (debug in [true, false]) ?

fabricedesre · 2017-03-02T18:03:59Z

support/android/apk/app/src/main/AndroidManifest.xml

-        package="com.mozilla.servo"
-        android:versionCode="1"
-        android:versionName="1.0">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android" android:installLocation="preferExternal"


Use auto as a value for installLocation, and move it to its own line.

fabricedesre · 2017-03-02T18:07:44Z