Heads up! This PR modifies the following files:

• @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/webdriver_handlers.rs, components/script/dom/bindings/error.rs, components/script/dom/bindings/conversions.rs, components/script/dom/htmlcanvaselement.rs, components/script/script_thread.rs, components/script/devtools.rs

Warning

• These commits modify unsafe code. Please review it carefully!
• These commits modify script code, but no tests are modified. Please consider adding a test!

r? @nox

@bors-servo try

⌛ Trying commit c0a2e36 with merge 53c0862...

💔 Test failed - linux-dev

@nox: I fixed tidy issues.

@bors-servo: try

⌛ Trying commit fff48e3 with merge 43151f7...

💔 Test failed - windows-dev

Retry please (windows tests didn't start apparently?)?

@bors-servo retry

⌛ Trying commit fff48e3 with merge 24ef817...

💔 Test failed - mac-rel-css

Is this intermittent?

Nope, and I think those are suspicious enough to deserve a bit of investigation. They're most likely caused by this changeset.

@bors-servo: try

A generated file: https://gist.github.com/GuillaumeGomez/227ee9b8b3a4d7f23b1193be7fe1a2c4

However I don't understand what you want:

and please add some unions with dictionaries to TestBinding so these paths are tested.

Which part do you not understand?

This patch makes Servo cope with unions including a dictionary type, so I want TestBinding (see TestBinding.webidl) to include some stuff with such unions.

I added @Ms2ger's suggestion.

Appveyor error is: "error: failed to build archive: bad archive: permission denied". Intermittent failure?

-S-awaiting-review +S-needs-code-changes

Reviewed 9 of 9 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

components/script/dom/htmlcanvaselement.rs, line 163 [r1] (raw file):

            let attrs = if let Some(webgl_attributes) = attrs {
                if let Ok(ConversionResult::Success(ref attrs)) = unsafe {

You didn't throw in the case of ConversionResult::Failure here.

components/script/dom/bindings/conversions.rs, line 87 [r1] (raw file):

                         -> Result<ConversionResult<Finite<T>>, ()> {
        let result = match FromJSValConvertible::from_jsval(cx, value, option) {
            Ok(ConversionResult::Success(v)) => v,

Missing throw on failure here.

components/script/dom/bindings/codegen/CodegenRust.py, line 5307 [r1] (raw file):

            initParent = ("parent: match try!(%s::%s::new(cx, val)) {\n"
                          "            ConversionResult::Success(v) => v,\n"
                          "            _ => return Err(()),\n"

Missing throw here.

Comments from Reviewable

components/script/dom/htmlcanvaselement.rs, line 163 [r1] (raw file):

Comments from Reviewable

Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

components/script/dom/bindings/conversions.rs, line 87 [r1] (raw file):

components/script/dom/bindings/codegen/CodegenRust.py, line 5307 [r1] (raw file):

Comments from Reviewable

Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

components/script/dom/htmlcanvaselement.rs, line 163 [r1] (raw file):

components/script/dom/bindings/conversions.rs, line 87 [r1] (raw file):

components/script/dom/bindings/codegen/CodegenRust.py, line 5307 [r1] (raw file):

Comments from Reviewable

Updated.

@bors-servo r+

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable

📌 Commit 2f3f4a5 has been approved by nox

⌛ Testing commit 2f3f4a5 with merge 3c4a08c...

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev