Heads up! This PR modifies the following files:

• @KiChjang: components/script_layout_interface/lib.rs, components/script/layout_interface.rs, components/script/dom/htmlcanvaselement.rs, components/script_layout_interface/Cargo.toml, components/script/lib.rs, components/script_layout_interface/restyle_damage.rs, components/script/Cargo.toml, components/script/dom/node.rs, components/script/layout_wrapper.rs, components/script_layout_interface/wrapper_traits.rs, components/script/dom/bindings/trace.rs

Warning

• These commits modify unsafe code. Please review it carefully!
• These commits modify gfx, layout, and script code, but no tests are modified. Please consider adding a test!

Great!

-S-awaiting-review +S-needs-code-changes

Reviewed 5 of 5 files at r1, 24 of 24 files at r2, 1 of 1 files at r3, 11 of 12 files at r4, 3 of 3 files at r5, 1 of 1 files at r6, 1 of 1 files at r7, 1 of 1 files at r8, 1 of 1 files at r9, 2 of 2 files at r10, 2 of 2 files at r11, 1 of 1 files at r12, 1 of 1 files at r13, 4 of 4 files at r14, 4 of 4 files at r15, 9 of 10 files at r16, 15 of 15 files at r17, 1 of 1 files at r18, 3 of 3 files at r19, 1 of 1 files at r20, 1 of 1 files at r21, 6 of 6 files at r22, 9 of 10 files at r23, 10 of 11 files at r24, 2 of 3 files at r25, 3 of 3 files at r26, 2 of 2 files at r27, 4 of 5 files at r28, 17 of 17 files at r29, 10 of 10 files at r30.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

components/layout/wrapper.rs, line 82 [r6] (raw file):

    fn type_id(&self) -> NodeTypeId;

    fn get_style_data(&self) -> Option<&RefCell<PartialStyleAndLayoutData>>;

Why do we need a RefCell here? Couldn't we have two methods style_data and style_data_mut returning Option<Ref<_>> and Option<RefMut<_>>?

components/layout/wrapper.rs, line 963 [r14] (raw file):

    ///
    /// TODO(pcwalton): Make this private. It will let us avoid borrow flag checks in some cases.
    #[inline(always)]

Does that actually do anything on a trait declaration?

components/script/dom/node.rs, line 2640 [r15] (raw file):

impl Into<NodeType> for NodeTypeId {
    fn into(self) -> NodeType {

Make that #[inline(always)].

components/script/dom/node.rs, line 2654 [r15] (raw file):

impl Into<ElementType> for ElementTypeId {
    fn into(self) -> ElementType {

Make that #[inline(always)].

components/script_layout_interface/lib.rs, line 71 [r15] (raw file):

    HTMLTableSectionElement,
    HTMLTextAreaElement,
}

Sorry but these names are going to be confusing. Please name them LayoutNodeType and LayoutElementType.

components/script_layout_interface/restyle_damage.rs, line 130 [r2] (raw file):

        Ok(())
    }
}

AFAIK bitflags! now generate a Debug implementation which basically does all of this, we should file an issue about simplifying this.

Comments from Reviewable

Reviewed 5 of 5 files at r1, 24 of 24 files at r2, 1 of 1 files at r3, 11 of 12 files at r4, 3 of 3 files at r5, 1 of 1 files at r6, 1 of 1 files at r7, 1 of 1 files at r8, 1 of 1 files at r9, 2 of 2 files at r10, 2 of 2 files at r11, 1 of 1 files at r12, 1 of 1 files at r13, 4 of 4 files at r14, 4 of 4 files at r15, 9 of 10 files at r16, 15 of 15 files at r17, 1 of 1 files at r18, 3 of 3 files at r19, 1 of 1 files at r20, 1 of 1 files at r21, 6 of 6 files at r22, 9 of 10 files at r23, 10 of 11 files at r24, 2 of 3 files at r25, 3 of 3 files at r26, 2 of 2 files at r27, 4 of 5 files at r28, 17 of 17 files at r29, 10 of 10 files at r30.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

Comments from Reviewable

@bors-servo r=nox

📌 Commit 1516a96 has been approved by nox

⌛ Testing commit 1516a96 with merge 9c8c346...

💔 Test failed - linux-rel

@bors-servo r=nox

📌 Commit b56821a has been approved by nox

@bors-servo p=10

⌛ Testing commit b56821a with merge ee8c5c5...

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows