Mostly complete new style system#1001
Merged
bors-servo merged 10 commits intoservo:masterfrom Oct 2, 2013
Merged
Conversation
Add a test: "parse bootstrap.css without failing"
bors-servo
pushed a commit
that referenced
this pull request
Oct 1, 2013
This is still not functional, (selector matching is missing) but sending what I have so far for review before the diff gets even bigger. (Most of the +7066 lines stat is for bootstrap.css, added as a test.)
Also make scribt::dom::element::Element::get_attr ASCII case-insensitive on attribute names, per spec: http://dom.spec.whatwg.org/#dom-element-getattribute
Member
Author
|
Add selector matching, and fix the missing license. (No amended commit) |
Contributor
|
I'm happy with merging this once you're convinced that |
Member
Author
|
@kmcallister, I’d like to have confirmation later, but I’m confident enough that |
bors-servo
pushed a commit
that referenced
this pull request
Oct 2, 2013
Add selector matching, style structs, cascading. The matching is quite naive and has many low hanging fruits for optimization. No pseudo-class (except `:not()`) is implemented yet, but those are easy to add as needed. Next step is to update the layout code to use this and drop netsurf-css. (Most of the +7066 lines stat is for bootstrap.css, added as a test.)
Member
Author
|
\o/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add selector matching, style structs, cascading. The matching is quite naive and has many low hanging fruits for optimization. No pseudo-class (except
:not()) is implemented yet, but those are easy to add as needed.Next step is to update the layout code to use this and drop netsurf-css.
(Most of the +7066 lines stat is for bootstrap.css, added as a test.)