Prevent parsing brackets from causing panic#108
Merged
SimonSapin merged 1 commit intoservo:masterfrom May 11, 2015
Merged
Conversation
dce2818 to
b0e900f
Compare
frewsxcv
added a commit
to frewsxcv/web-platform-tests
that referenced
this pull request
May 11, 2015
Contributor
Author
|
Dont merge this yet, theres another bug in here |
Member
|
Nice! But I think a similar issue exists for |
Contributor
Author
|
@SimonSapin Yeah, I was just about to add that in :) |
The code:
```
Url::parse("http://[]")
```
The panic:
```
thread '<main>' panicked at 'index out of bounds: the len is 0 but the index is 0',
/Users/coreyf/.cargo/registry/src/github.com-1ecc6299db9ec823/url-0.2.34/src/host.rs:104
```
in addition to:
The code:
```
Url::parse("http://[:]")
```
The panic:
```
/Users/coreyf/.cargo/registry/src/github.com-1ecc6299db9ec823/url-0.2.34/src/host.rs:104
thread 'tests::url_parsing' panicked at 'index out of bounds: the len is
1 but the index is 1', src/host.rs:110
```
Was found using https://github.com/kmcallister/afl.rs 👍
http://[] from causing panic
frewsxcv
added a commit
to frewsxcv/web-platform-tests
that referenced
this pull request
May 11, 2015
frewsxcv
added a commit
to frewsxcv/web-platform-tests
that referenced
this pull request
May 11, 2015
Contributor
Author
|
Should be reviewable; tests pass |
SimonSapin
added a commit
that referenced
this pull request
May 11, 2015
Prevent parsing brackets from causing panic
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code:
The panic:
in addition to:
The code:
The panic:
Was found using https://github.com/kmcallister/afl.rs 👍