Never run ragel when generated files exist#173
Conversation
|
r? @jdm |
jdm
left a comment
There was a problem hiding this comment.
Despite the fact that a bunch of updates to harfbuzz have merged since the last harfbuzz-sys release April, I've checked the changes to the Rust library and doing a minor version update here looks ok to me.
| # We decided to add ragel-generated files to git... | ||
| #MAINTAINERCLEANFILES += $(RAGEL_GENERATED) | ||
| $(srcdir)/%.hh: $(srcdir)/%.rl | ||
| $(srcdir)/%.hh: |
There was a problem hiding this comment.
If we apply this change, we need some way to preserve this when we update harfbuzz to new releases, which happens fairly regularly.
|
Rather than changing an in-tree makefile, let's update https://github.com/servo/rust-harfbuzz/blob/master/harfbuzz-sys/makefile.touch with the hh files instead. |
65cb8a0 to
129e6b7
Compare
|
@bors-servo r+ |
|
📌 Commit 129e6b7 has been approved by |
Never run ragel when generated files exist This is untested, but hopefully works around servo/servo#24611. This is not suitable for development of Harfbuzz itself (as opposed to bindings), but hopefully that doesn’t happen in this repository and being required to run `cargo clean` after updating the Harfbuzz version is acceptable.
|
☀️ Test successful - checks-travis |
… to pick up servo/rust-harfbuzz#173, which hopefully fixes #24611
… to pick up servo/rust-harfbuzz#173, which hopefully fixes #24611
Update harfbuzz-sys … to pick up servo/rust-harfbuzz#173, which hopefully fixes #24611
|
This is another thing that would be fixed by PR #170 |
This is untested, but hopefully works around servo/servo#24611.
This is not suitable for development of Harfbuzz itself (as opposed to bindings), but hopefully that doesn’t happen in this repository and being required to run
cargo cleanafter updating the Harfbuzz version is acceptable.