Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
=======================================
Coverage 78.43% 78.43%
=======================================
Files 19 19
Lines 1354 1354
=======================================
Hits 1062 1062
Misses 219 219
Partials 73 73 ☔ View full report in Codecov by Sentry. |
sadlerap
reviewed
Mar 1, 2024
Contributor
sadlerap
left a comment
There was a problem hiding this comment.
LGTM, but let's hold on merging this until the spec has released v1 resources.
servicebinding.io/v1beta1 remains supported. There is no difference in functionality between v1 and v1beta1. v1beta1 is defined in the semantics of v1, along with v1alpha3 (which remains deprecated, yet functional). We can choose to deprecate v1beta1 in the future. Signed-off-by: Scott Andrews <scott@andrews.me>
dfdc3b9 to
a8721d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
servicebinding.io/v1beta1remains supported. There is no difference in functionality betweenv1andv1beta1.v1beta1is defined in the semantics ofv1, along withv1alpha3(which remains deprecated, yet functional).We can choose to deprecate
v1beta1in the future.Refs servicebinding/spec#226