Promote API servicebinding.io/v1beta1 -> v1#226
Merged
scothis merged 1 commit intoservicebinding:mainfrom Mar 12, 2024
Merged
Conversation
Member
Author
|
Intent is to hold this PR for feedback until the next community call on March 12th. |
nebhale
approved these changes
Feb 27, 2024
sadlerap
approved these changes
Mar 11, 2024
Contributor
|
LGTM, provided the merge conflicts are fixed. |
The spec and CRDs have been stable for quite some time. We feel comfortable promoting the v1beta1 APIs to v1. Implementations are free to continue to support the v1beta1 API for as long as they see fit. Also updating the scripts to generate the exemplar CRDs to use the latest dependencies. Signed-off-by: Scott Andrews <scott@andrews.me>
Member
Author
|
rebased to fix conflict |
sadlerap
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec and CRDs have been stable for quite some time. We feel comfortable promoting the v1beta1 APIs to v1. Implementations are free to continue to support the v1beta1 API for as long as they see fit.
Also updating the scripts to generate the exemplar CRDs to use the latest dependencies.