Migrate from VMware implementation#336
Merged
sadlerap merged 1 commit intoservicebinding:mainfrom Sep 14, 2023
Merged
Conversation
Merged
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
==========================================
- Coverage 81.44% 78.36% -3.09%
==========================================
Files 17 19 +2
Lines 1450 1627 +177
==========================================
+ Hits 1181 1275 +94
- Misses 221 281 +60
- Partials 48 71 +23
☔ View full report in Codecov by Sentry. |
a1072f4 to
fc818cc
Compare
sadlerap
reviewed
Sep 14, 2023
Contributor
sadlerap
left a comment
There was a problem hiding this comment.
I'm going to assume the hooks are correct, since I don't know enough about vmware's implementation to know if they're correct or not.
Got one small question, otherwise LGTM.
sadlerap
approved these changes
Sep 14, 2023
Contributor
sadlerap
left a comment
There was a problem hiding this comment.
lgtm, just waiting on ci
Hooks to migrate from the VMware implementation are available opt-in by passing the --migrate-from-vmware flag to the manager container. Running with the migration hooks installed will incur a performance penalty and should only be used while a migration is active, and then disabled. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
fc818cc to
2351b2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hooks to migrate from the VMware implementation are available opt-in by
passing the --migrate-from-vmware flag to the manager container. Running
with the migration hooks installed will incur a performance penalty and
should only be used while a migration is active, and then disabled.
Depends on #327