Merged
Conversation
Member
Author
|
Untested, posting for high level feedback on the direction. cc @sadlerap |
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
- Coverage 81.44% 79.43% -2.02%
==========================================
Files 17 18 +1
Lines 1450 1493 +43
==========================================
+ Hits 1181 1186 +5
- Misses 221 249 +28
- Partials 48 58 +10
☔ View full report in Codecov by Sentry. |
Member
Author
|
Moved the VMware specific bits out to #336 |
The hooks allow defining a custom Resolver or Projector as well as interacting with the ServiceBinding and workload resources before before and after projection. Defining no hooks is equivalent to the current RI behavior. The controller operates on a single ServiceBinding and zero-to-many workloads in a single request, while the webhook operates on a single workload with zero-to-many ServiceBindings. Because of this mismatch, we split out interactions with the ServiceBinding and workload resources into independent hooks. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Member
Author
|
rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hooks allow defining a custom Resolver or Projector as well as interacting with the ServiceBinding and workload resources before before and after projection.
Defining no hooks is equivalent to the current RI behavior.
The controller operates on a single ServiceBinding and zero-to-many workloads in a single request, while the webhook operates on a single workload with zero-to-many ServiceBindings. Because of this mismatch, we split out interactions with the ServiceBinding and workload resources into independent hooks.
Depends on #335