Include cert-manager for local deployment#154
Merged
baijum merged 4 commits intoservicebinding:mainfrom Aug 6, 2022
Merged
Conversation
baijum
commented
Aug 5, 2022
db265ee to
edb0979
Compare
scothis
requested changes
Aug 5, 2022
Member
scothis
left a comment
There was a problem hiding this comment.
We cannot automatically install cert-manager as it will inherently conflict with any existing install of cert-manager that happens to be in the cluster. We can have independent make targets to install/uninstall cert-manager, we just can't depend on them in any of the other targets.
baijum
commented
Aug 5, 2022
Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
Contributor
Author
I have removed the dependency. Also added a note about the make target in the README. |
scothis
reviewed
Aug 5, 2022
Co-authored-by: Scott Andrews <scott@andrews.me> Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
scothis
approved these changes
Aug 5, 2022
sadlerap
pushed a commit
to sadlerap/service-binding-runtime
that referenced
this pull request
Aug 24, 2022
Co-authored-by: Scott Andrews <scott@andrews.me> Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Baiju Muthukadan baiju.m.mail@gmail.com