Skip to content

Fix Required Minimum indexmap Version#590

Merged
dtolnay merged 1 commit intoserde-rs:masterfrom
nlordell:bump_indexmap_version
Dec 4, 2019
Merged

Fix Required Minimum indexmap Version#590
dtolnay merged 1 commit intoserde-rs:masterfrom
nlordell:bump_indexmap_version

Conversation

@nlordell
Copy link
Copy Markdown
Contributor

@nlordell nlordell commented Dec 4, 2019 •
edited
Loading

The preserve-order feature uses indexmap::map::OccupiedEntry::swap_remove method which was only added in 1.2, however, the Cargo.toml incorrectly requires ^1.0.

@nlordell nlordell changed the title fix required minimum indexmap version Fix Required Minimum indexmap Version Dec 4, 2019
@nlordell nlordell mentioned this pull request Dec 4, 2019
Merged
dtolnay
dtolnay approved these changes Dec 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 76b2366 into serde-rs:master Dec 4, 2019
@dtolnay
Copy link
Copy Markdown
Member

dtolnay commented Dec 4, 2019

Published in 1.0.43.

takumi-earth pushed a commit to earthlings-dev/json that referenced this pull request Jan 27, 2026
@dtolnay
Merge pull request serde-rs#590 from nlordell/bump_indexmap_version
f8d70dd 
Fix Required Minimum `indexmap` Version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nlordell @dtolnay