feat: support ignoreDuplicates in Postgres >= 9.5 #9883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sushantdhiman looks like AppVeyor failed for no good reason, I can't see why in the log |
sushantdhiman
approved these changes
Sep 6, 2018
Contributor
|
Make sure this test is running for postgres https://github.com/sequelize/sequelize/blob/master/test/integration/model/bulk-create.test.js#L425 You will need to include |
Contributor
Author
|
@sushantdhiman okay it's fixed, the test had a transient failure. |
Contributor
|
Thanks @jedwards1211 |
Contributor
Author
|
Thank you! |
|
Hello, do you have any idea when this will be released? |
jhiner
pushed a commit
to jhiner/sequelize
that referenced
this pull request
Sep 24, 2018
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Closes #9882