change(model): setDataValue shouldn't set attribute as changed when u… #9347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kirill89
approved these changes
Apr 24, 2018
Contributor
|
@sushantdhiman, can you please take a look? |
eseliger
approved these changes
Apr 29, 2018
sushantdhiman
suggested changes
Apr 29, 2018
Contributor
sushantdhiman
left a comment
There was a problem hiding this comment.
New test should be using .set not .setDataValue
Contributor
|
@sushantdhiman, but we are checking functionality of |
Contributor
sushantdhiman
left a comment
There was a problem hiding this comment.
I see there is already a test for .set primitive null case.
Just move this test under new describe and rebase your branch with master. Then it should be good to go
test/unit/instance/changed.test.js
Outdated
| expect(user.changed('meta')).to.equal(false); | ||
| }); | ||
|
|
||
| it('should return falsy for unchanged primitive via setDataValue', function() { |
Contributor
There was a problem hiding this comment.
move this one new test under describe('setDataValue'), as it's testing setDataValue
sushantdhiman
approved these changes
Apr 29, 2018
davegw
added a commit
to davegw/sequelize
that referenced
this pull request
Jan 3, 2019
davegw
added a commit
to davegw/sequelize
that referenced
this pull request
Jan 4, 2019
…from null to null v3 port of sequelize#9347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pdated from null to null #5004
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change