Skip to content

Conversation

@ruimarinho
Copy link
Contributor

Adds support for postgres on io.js.

  • Upgrade pg@4.2.0
  • Upgrade pg-native@1.8.0

Two important notes:

  • There is a new SET that increases the message level to warning (up from notice) since the upgraded pg client is now capable of bubbling these messages.
  • There is something going on with timers that I had to workaround with promises. The tests where sinon's fake clock are used hang for some reason. This doesn't seem related to io.js since the lib tests used by sinon to fake timers are passing on the latest io.js version. If anyone is able to figure that out, I'd appreciate it.

@ruimarinho ruimarinho force-pushed the enhancement/upgrade-pg-and-pg-native branch 3 times, most recently from 7278933 to 77c0768 Compare February 1, 2015 03:59
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use return this.sequelize.Promise.delay(1000)

@janmeier
Copy link
Member

janmeier commented Feb 2, 2015

I've experienced problems with the combination of promises and fake timers as well. If you change it to Promise.timeout it should be fine

@ruimarinho ruimarinho force-pushed the enhancement/upgrade-pg-and-pg-native branch from 77c0768 to dd4fc8e Compare February 2, 2015 10:21
@ruimarinho
Copy link
Contributor Author

@janmeier fixed and rebased.

janmeier added a commit that referenced this pull request Feb 2, 2015
…-pg-native

Add support for postgres on io.js
@janmeier janmeier merged commit 52916fb into sequelize:master Feb 2, 2015
@janmeier
Copy link
Member

janmeier commented Feb 2, 2015

@ruimarinho merged and thanks sent :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants