feat(postgres): allow customizing client_min_messages #10448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
For some reason, Sequelize sets
client_min_messagestowarningwhen connecting to Postgres. This was introduced in #3041 with the only justification being "There is a newSETthat increases the message level towarning(up fromnotice) since the upgraded pg client is now capable of bubbling these messages."pgdoes indeed allow you to register an event when the server returns a message, but it doesn't follow that Sequelize needs to override the defaultclient_min_messages.Furthermore, this behavior accidentally became coupled to the
keepDefaultTimezonesetting in 95a5c0d. WhenkeepDefaultTimezoneistrue,client_min_messagesis not overridden.This behavior has been in place so long that it may be safest to keep
client_min_messagesset towarningby default. But we can at least allow users to customize it and decouple it fromkeepDefaultTimezone.If we want to make a riskier change, we can set
client_min_messagestonullby default and have Sequelize default to not updating the DB's setting. I have not done that in this PR, but it's an easy change if we want to make it.