Skip to content

Conversation

@tiwarishubham635
Copy link
Contributor

Fixes

  1. Removed public SetHost() as it is not required for Go [SetDataResidency does exactly the same thing]
  2. Shifted SetDataResidency() to sendgrid.go since it is specific to that only. Earlier it was in base_interface.go which means if someone creates a twilio_email request, then also they would be able to access SetDataResidency() and overrides host. But that doesn't make sense since it is specific to sendgrid only.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@tiwarishubham635 tiwarishubham635 merged commit ec79368 into main Nov 23, 2023
@tiwarishubham635 tiwarishubham635 deleted the remove_set_host branch November 23, 2023 08:56
qhenkart pushed a commit to qhenkart/sendgrid-go that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants