fix: failing release due to renamed repository#878
Merged
Conversation
…tory name has been changed"`
gr2m
approved these changes
Jul 19, 2024
Member
gr2m
left a comment
There was a problem hiding this comment.
Just a few nits but otherwise good to go
|
🎉 This issue has been resolved in version 10.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
@gr2m breaking change...just because we have an https:// URL in our |
Contributor
|
@gr2m also I can't seem to make this error go away. The |
|
|
||
| export function EMISMATCHGITHUBURL() { | ||
| return { | ||
| message: "The git repository URL mismatches the GitHub URL.", |
Contributor
There was a problem hiding this comment.
@gr2m @babblebey it would be a lot more convenient to include the two values that didn't match in an error message like this
gr2m
added a commit
that referenced
this pull request
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request introduces an extra step in the plugin
verifylifecycle which verifies that therepositoryUrland/or project package.json'srepositoryfield matches the project's current GitHub URL. This throws an errorEMISMATCHGITHUBURLwhich confirms mismatch and suggests a fix.Changes Made
Added a logic that requests the repo details leveraging the github get-a-repository endpoint, and checks for a
statusof200and a match between the response data'sclone_urlvalue and thecontext.options.repositoryUrl. And it should only run this when we agithubTokenis authenticated and we do not have theEINVALIDPROXYandEMISSINGREPOerror.Added a new error helper function
EMISMATCHGITHUBURLfor theRelated Issue
Fixes #803
Screencast/Screenshot
screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.07.14-11_29_00.webm