Merged
Conversation
support index is -1
Owner
|
Thanks for the MR, but I'll check with Ramda behavior before approving it. |
Owner
|
I added a test for negative index and I found out that the results for Rambda and Ramda match. This means that it currently works even without the line you are adding. I'll close this MR, but feel free to comment further. |
Owner
|
Sorry, it was my mistake. You are correct that without this line, there are equal results for index of |
selfrefactor
added a commit
that referenced
this pull request
Dec 16, 2021
* feat: test new type of benchmark with r.uniq * feat: introduce benchmark helper util * feat: apply new benchmark with r.index.of * chore: change benchmark commands * feat: introduce additional benchmark modes * feat: improve r.uniq.with benchmark * feat: improve speed of r.uniq.with * feat: new format for r.all * benchmark: r.all.pass * test: r.update with negative index * feat: add total test count in brute force test * Update update.js (#593) support index is -1 * fix: r.update with negative index * fix: wrong value for total tests * chore: lint all * test: missing rambda type for sets * test: brute force for r.equals * chore: test patch-package in ci env * chore@small * chore: test rambdax with patch.package * chore: run with lodash * feat: add set as return value of r.type * chore: small changes of r.apply mr * fix: wrong r.drop.repeats.with documentation * feat: change ci node versions * chore: small * feat: change r.compose typings * feat: r.reduce skip throw on falsy iterable * chore: revert r.reduce changes * fix: circular dependency * test: r.length * fix: r.length * test: r.compose length * fix@issue #604 r.all.pass with multiple inputs * feat@issue #604 r.any.pass with multiple inputs * test: r.head with empty array * fix: typings test * chore@dnd * feat@typings r.pipe * feat@typings revert to old r.pipe * fix@typings r.compose is copy of r.pipe * test@typing r.compose * chore@dnd * feat@typings r.last * feat@typings r.head * chore: add code tour * chore@dnd * fix: rollup config * chore@dnd * fix@issue #595 improve list cloning * fix: jest extended * test@typings r.compose and r.pipe with complex explicit types * fix@important sync r.compose r.pipe typings * fix@issue #608 r.compose benchmarks * feat@typings r.unless * fix: r.last.index.of * fix: error as valid return for r.type * feat: r.ends.with support lists as input * test: brute force * feat: clone list util * fix: remove bad r.chain typing * fix@typings r.dissoc * feat@important export types and babel config rename * feat: r.type with ramda logic * fix: missing typing for r.compose * fix@typings r.merge * fix: r.identical test * feat@important throw on bad inputs with r.map r.filter * chore: r.pipe benchmark * fix: typings tests * chore@dnd * fix: r.pipe benchmark * fix: unit tests * chore: build * feat@lint * feat: change node versions in ci * fix: use only two node versions in ci * fix: parse error Co-authored-by: Dejan Totev <dejan.totev@psinteractive.io> Co-authored-by: zdzDesigner <1696498456@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support index is -1