Skip to content

v0.0.20-alpha-2#84

Merged
qlrd merged 64 commits intoselfcustody:mainfrom
qlrd:main
Sep 23, 2024
Merged

v0.0.20-alpha-2#84
qlrd merged 64 commits intoselfcustody:mainfrom
qlrd:main

Conversation

@qlrd
Copy link
Member

@qlrd qlrd commented Sep 21, 2024

  • Changed the version from 0.0.2-alpha to 0.0.20-alpha-2 as suggested by @odudex;
  • Refactored the code a little bit to be more pythonic;
  • Removed startup messages as suggested by @tadeubas:
    • On linux the GreetingsScreen class will check:
      • if user is on dialout/uucp group (debian and fedora based / archlinux);
      • internet connection
    • On MacOS an Windows the GreetingsScreen class will check:
      • internet connection
  • Added the window resize behaviour;
  • Removed fullscreen on startup;
  • Fedora and Ubuntu:
    • fixed desktop icon entry on .ci/create-deb;
    • fixed desktop icon entry on .ci/create-rpm;
  • Added more tests:
    • ask_permissions_dialout_screen;
    • error_screen.

qlrd and others added 30 commits August 30, 2024 07:56
Separated workflow runs
on_data function defined dynamically
removed check screens

startup checks go to GreetingsScreen

removed markup arguments on some widgets

linted many files
changed some methods to standardized name ones, on_data, on_process, on_done
re-structured build process on CI
refactored part of main_screen due to linting

refactored many tests after linting
didnt coveraged the frozen and _MEIPASS due to difficulty to add mocked attributes to sys module
@qlrd qlrd requested review from jdlcdl, odudex and tadeubas September 21, 2024 00:04
@github-actions
Copy link

👋 Hey there kruxer. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:

  • .gitignore
  • .pylintrc
  • TODO.md
  • CHANGELOG.md
  • LICENSE

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

More discussion:

removed .pylintrc, TODO and .gitignore from CI workflow
@codecov
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 96.53122% with 35 lines in your changes missing coverage. Please review.

Project coverage is 97.06%. Comparing base (344576d) to head (7eaf2ac).
Report is 85 commits behind head on main.

Files with missing lines Patch % Lines
src/app/screens/main_screen.py 94.76% 6 Missing and 3 partials ⚠️
src/app/screens/wipe_screen.py 79.06% 8 Missing and 1 partial ⚠️
src/app/screens/flash_screen.py 84.09% 6 Missing and 1 partial ⚠️
src/app/screens/base_screen.py 90.90% 5 Missing and 1 partial ⚠️
src/app/screens/greetings_screen.py 96.66% 0 Missing and 2 partials ⚠️
src/app/screens/error_screen.py 96.00% 0 Missing and 1 partial ⚠️
src/app/screens/select_device_screen.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   89.75%   97.06%   +7.30%     
==========================================
  Files          61       60       -1     
  Lines        3026     2692     -334     
  Branches      482      350     -132     
==========================================
- Hits         2716     2613     -103     
+ Misses        222       62     -160     
+ Partials       88       17      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qlrd qlrd self-assigned this Sep 21, 2024
@qlrd qlrd linked an issue Sep 21, 2024 that may be closed by this pull request
Copy link
Member

@odudex odudex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@qlrd qlrd merged commit 38acc3c into selfcustody:main Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Font size not change when window is resized

2 participants