Skip to content

v0.0.20-alpha-2#10

Merged
qlrd merged 41 commits intomainfrom
develop
Sep 13, 2024
Merged

v0.0.20-alpha-2#10
qlrd merged 41 commits intomainfrom
develop

Conversation

@qlrd
Copy link
Owner

@qlrd qlrd commented Sep 13, 2024

  • Changed the version from 0.0.2-alpha to 0.0.20-alpha-2 as suggested by @odudex;
  • Removed startup messages as suggested by @tadeubas:
    • On linux the GreetingsScreen class will check:
      • if user is on dialout/uucp group;
      • internet connection
    • On MacOS an Windows the GreetingsScreen class will check:
      • internet connection
  • Added a line on .ci/create-deb for add user to input on debian-based systems where
    require permissions for /dev/input/eventX (thanks to @theautumnbridge);
  • Refactored the code a little bit to be more pythonic one;
  • Added more tests:
    • ask_permissions_dialout_screen;
    • error_screen.

qlrd and others added 30 commits August 30, 2024 11:30
on_data function defined dynamically
removed check screens

startup checks go to GreetingsScreen

removed markup arguments on some widgets

linted many files
changed some methods to standardized name ones, on_data, on_process, on_done
re-structured build process on CI
refactored part of main_screen due to linting

refactored many tests after linting
didnt coveraged the frozen and _MEIPASS due to difficulty to add mocked attributes to sys module
substituted button on warning_beta_screen to label with a image
@github-actions
Copy link

👋 Hey there kruxer. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:

  • .gitignore
  • .pylintrc
  • TODO.md
  • CHANGELOG.md
  • LICENSE

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

More discussion:

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.79811% with 78 lines in your changes missing coverage. Please review.

Project coverage is 94.76%. Comparing base (cf3d221) to head (61bb567).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/app/screens/greetings_screen.py 29.03% 41 Missing and 3 partials ⚠️
src/app/screens/wipe_screen.py 77.27% 9 Missing and 1 partial ⚠️
src/app/screens/main_screen.py 94.57% 6 Missing and 3 partials ⚠️
src/app/screens/flash_screen.py 81.81% 7 Missing and 1 partial ⚠️
src/app/screens/base_screen.py 85.29% 4 Missing and 1 partial ⚠️
src/app/screens/error_screen.py 96.55% 0 Missing and 1 partial ⚠️
src/app/screens/select_device_screen.py 87.50% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   89.75%   94.76%   +5.01%     
==========================================
  Files          61       60       -1     
  Lines        3026     2751     -275     
  Branches      482      354     -128     
==========================================
- Hits         2716     2607     -109     
+ Misses        222      120     -102     
+ Partials       88       24      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qlrd qlrd merged commit e32f89a into main Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants