-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Simplified Norwegian(nb) translation to a more correct text #4817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi. I have also modified this file. The word "til" implies "more" so it might be better to go for this: What do you think? |
|
Please disregard my comment. I reverted my changes and used same as you. Yours is closer to the current English version. |
|
@alexweissman The rule in Norwegian is that small numbers are written as a word, for that reason I like the idea to use "ett" instead of "1". However, I do have a feeling that if you also should write "two" and "three" ("to", "tre") if you are using words, which is the reasoning behind my commit (also it's easier to read) I'm not sure which is more correct of the two solutions, but both are better than the original |
|
Ok, so from what I understand, it looks like #4896 is a good alternative to your commit, but if you wanted to add some logic for "to" and "tre", that would be even better? |
|
Looked it up to be sure..
I'm fairly sure the "emphasize the numerical value" could be used as an argument to not use "ett", but instead keep 1 |
|
I don't really care as long as the message is understandable and correct so #4817 gets my vote. |
|
#4817 gets my vote too. |
|
Alright, we'll get this merged in with the next release! |
This pull request includes a
The following changes were made