Skip to content

Conversation

@bovan
Copy link

@bovan bovan commented Mar 2, 2017

This pull request includes a

  • Bug fix
  • New feature
  • Translation

The following changes were made

  • Simplified norwegian text to a more correct one

@ToreOlavKristiansen
Copy link
Contributor

ToreOlavKristiansen commented Apr 8, 2017

Hi.

I have also modified this file. The word "til" implies "more" so it might be better to go for this:

inputTooShort: function (args) {
      var remainingChars = args.minimum - args.input.length;

      var message = 'Vennligst skriv inn minst ';

      if (remainingChars > 1) {
        message += t + ' tegn';
      } else {
        message += ' et tegn til';
      }

      return message;
    }

What do you think?

@ToreOlavKristiansen
Copy link
Contributor

Please disregard my comment. I reverted my changes and used same as you. Yours is closer to the current English version.

@alexweissman
Copy link
Contributor

This appears to conflict with #4896. Could @bovan and @freost please discuss this to determine which is more correct?

@bovan
Copy link
Author

bovan commented Sep 24, 2017

@alexweissman The rule in Norwegian is that small numbers are written as a word, for that reason I like the idea to use "ett" instead of "1".

However, I do have a feeling that if you also should write "two" and "three" ("to", "tre") if you are using words, which is the reasoning behind my commit (also it's easier to read)

I'm not sure which is more correct of the two solutions, but both are better than the original

@alexweissman
Copy link
Contributor

Ok, so from what I understand, it looks like #4896 is a good alternative to your commit, but if you wanted to add some logic for "to" and "tre", that would be even better?

@bovan
Copy link
Author

bovan commented Sep 25, 2017

Looked it up to be sure..

Typically, letters in small numbers (0-12) are used in running text:
Nils is five years old. He has three football balls.
But sometimes you want to emphasize the numerical value or be more precise , and then it's natural to use numbers

I'm fairly sure the "emphasize the numerical value" could be used as an argument to not use "ett", but instead keep 1

@freost
Copy link
Contributor

freost commented Sep 25, 2017

I don't really care as long as the message is understandable and correct so #4817 gets my vote.

@ToreOlavKristiansen
Copy link
Contributor

#4817 gets my vote too.

@alexweissman
Copy link
Contributor

Alright, we'll get this merged in with the next release!

alexweissman added a commit that referenced this pull request Sep 26, 2017
@alexweissman alexweissman added this to the 4.0.5 milestone Sep 27, 2017
@alexweissman alexweissman merged commit 9461492 into select2:master Oct 23, 2017
@freost freost mentioned this pull request Dec 4, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants