Fixes #3712 Allowing Pasting tags from spreadsheet #4795
Conversation
I was trying to make an easy way for clients to copy and paste tags from a spreadsheet, but I was unable to do this because select2's use of a 'search' input would remove all newline characters from the pasted input. replacing the search text input with a textarea removes this limitation.
|
clearly this needs more work. |
3b31347 to
7c6d350
Compare
|
@kevin-brown Our company is running a fork of select2 in order to have this functionality, so I'm running this code in production without issue, What can I do to get this pr accepted so that I can get back to running the master trunk? |
|
@alexweissman are you a new maintainer? what do I need to do to get this in? |
|
I'm a "maintainer-in-training". My main goal is to improve the documentation and get the obvious bug fixes merged in. This looks like a good feature, but it has the potential to create breaking changes for anyone who is expecting an |
|
sounds good, I'll get to work. |
|
@alexweissman I've sorted this out and written the change to config. The code passes tests and I've tested this in our environment. if searchElement = 'textarea' a textarea will be used, otherwise an input will be used as usual, so this should not change backward compatibility. |
|
documentation pull request here: select2/docs#27 |
|
Unfortunately this pull request contains files in the If you are still interested in making this contribution, feel free to remove the |
|
@kevin-brown I've done this, how does it look now? |
|
@kevin-brown @alexweissman Just pinging this again, can I merge it in? |
|
Is there a reason why we wouldn't just switch it to always use a |
|
I hope this can be merged soon, thank you so much for you continuing to work on this one. |
|
@kevin-brown none really, I only did it to satisfy @alexweissman (several comments above) |
|
Anything I can do to help this along? |
|
@kevin-brown I've updated this with the latest. |
|
@kevin-brown can you give me a status update as to what your plan is here? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
stalebot... |
I was trying to make an easy way for clients to copy and paste tags from a spreadsheet, but I was unable to do this because select2's use of a 'search' input would remove all newline characters from the pasted input. replacing the search text input with a textarea removes this limitation.
This pull request includes a
The following changes were made
Replaced
<input type="search" />with<textarea></textarea>If this is related to an existing ticket, include a link to it as well.