Fix: Don't test botan installation in CI (broken cmake test)#159
Closed
Fix: Don't test botan installation in CI (broken cmake test)#159
Conversation
reneme
added a commit
to Rohde-Schwarz/botan
that referenced
this pull request
Dec 11, 2023
Before we just hard-coded the TPM module. Though, this causes issues when running the test in a build configuration where TPM is actually available. Like in the BSI build configurations. See also: sehlen-bsi/botan-docs#159
FAlbertDev
approved these changes
Dec 11, 2023
reneme
added a commit
to Rohde-Schwarz/botan
that referenced
this pull request
Dec 11, 2023
Before we just hard-coded the TPM module. Though, this causes issues when running the test in a build configuration where TPM is actually available. Like in the BSI build configurations. See also: sehlen-bsi/botan-docs#159
Collaborator
Author
|
Fixed and merged upstream. Closing. |
Collaborator
Author
|
As a side note: The main branch is currently broken, because it points to an upstream revision that doesn't contain the patch, yet. After tonight's Auto-Update run, this should become fixed. |
Thiesius
pushed a commit
to Roboauto/botan
that referenced
this pull request
May 20, 2024
Use furo Sphinx theme Add OpenSSL 1.1 to Botan 3.x migration guide FIX: handling of TLS protocol errors in the ASIO wrapper A complete revamp of the state management in the ASIO stream wrapper to properly disentangle TLS state transitions even when receiving coalesced TLS records. Those can result in multiple state changes of Botan's underlying TLS implementation. For extensive technical details and a higher-level problem description, please see randombit#3801. Co-Authored-By: René Meusel <rene.meusel@rohde-schwarz.com> Add check to SM2_PrivateKey::check_key() that private key x is in ]0, q-1[ ./botan tls_client_hello can deal with TLS 1.3 Add Private_Key::remaining_operations() (randombit#3706) FIX: clang-tidy warnings Extend documentation for encryption and signing parameters note disabled modules in build/build_config.json Dynamically select a disabled module for the CMake test Before we just hard-coded the TPM module. Though, this causes issues when running the test in a build configuration where TPM is actually available. Like in the BSI build configurations. See also: sehlen-bsi/botan-docs#159 Mention CMake configuration in docs ./configure.py --without-cmake-config disables cmake integration Add sig algos and key agreements to bench.py Co-authored-by: René Meusel <github@renemeusel.de> Update Doxygen landing page Adding references to XOF (base class), PK_KEM_En/Decryptor, Kuznyechik, BLAKE2b (as a MAC), KMAC, KEMs (Kyber, RSA), Dilithium, SPHINCS+ and SHAKE (as a XOF) FIX: don't assume that 'tpm' is generally not available This is a follow-up of 971d7d5 Cleanup after merge master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... this is just a quick-fix to get a green CI again. Will improve the test upstream.