Skip to content

LF-34618 Qt dashed line drawing.#2

Merged
BenLewis-Seequent merged 7 commits into5.14.2from
LF-34618-section-layout-line-width
Oct 20, 2020
Merged

LF-34618 Qt dashed line drawing.#2
BenLewis-Seequent merged 7 commits into5.14.2from
LF-34618-section-layout-line-width

Conversation

@BenLewis-Seequent
Copy link

@BenLewis-Seequent BenLewis-Seequent commented Oct 15, 2020

Improves dashed line drawing. This is only used when the render hint 0x80 is set, so will not affect anywhere else that doesn't explicitly set that render hint.

@BenLewis-Seequent BenLewis-Seequent merged commit 552fd6d into 5.14.2 Oct 20, 2020
denis-simo pushed a commit that referenced this pull request Jan 19, 2021
Our authentication code is race-y by design:
1. When two requests are fired off and queued at the same time in the
same QHttpNetworkConnection then if one of them encounters
"authentication required" then it will copy whatever credentials it got
to all the other channels in the connection. This is likely what the
first part of the test is testing.
2. If a later request is fired off and it includes credentials in the
url then the newly included credentials should be used instead of the
cached ones.

The race here can occurr when one socket either takes too long to
connect or the connected signal is not received early enough. Then the
first socket is used for both requests and then we can hit case #2 when
the url contains credentials.

Change-Id: I646a5378d8c1256b2de98b51912953df29f68cb2
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
(cherry picked from commit 5a47939)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
@ThomasMatern ThomasMatern deleted the LF-34618-section-layout-line-width branch September 18, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants