Skip to content

Ensure Host findings still have a valid location even when they are not named #3451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Reet00 merged 2 commits into from
Jan 9, 2026
Merged

Ensure Host findings still have a valid location even when they are not named #3451

Reet00 merged 2 commits into from
Jan 9, 2026
+5 −5

Conversation

@J12934
Copy link
Member

@J12934 J12934 commented Jan 7, 2026

Description

Noticed some nmap findings were missing locations which is kinda inconsistent

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

J12934 added 2 commits January 7, 2026 10:36
@J12934
Ensure Host findings still have a valid location even when they are not
ba1b8d1 
named

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@J12934
Update snapshots to include location for unnamed hosts
a5325d3 
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@J12934 J12934 self-assigned this Jan 7, 2026
@J12934 J12934 added the bug Bugs label Jan 7, 2026
@netlify
Copy link

netlify bot commented Jan 7, 2026 •
edited
Loading

✅ Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit a5325d3
🔍 Latest deploy log https://app.netlify.com/projects/docs-securecodebox/deploys/695e2a397fca3c0008308a9a

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Reet00
Reet00 approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@Reet00 Reet00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-project-automation github-project-automation bot moved this from Triage to Reviewer Approved in secureCodeBox Jan 9, 2026
@Reet00 Reet00 merged commit 31d9ab0 into secureCodeBox:main Jan 9, 2026
50 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in secureCodeBox Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Reet00 Reet00 Reet00 approved these changes

Assignees

@J12934 J12934

Labels

bug Bugs

Projects

secureCodeBox
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@J12934 @Reet00