Skip to content

Dumb: disable tests that failed once#3413

Merged
guedou merged 1 commit intosecdev:masterfrom
gpotter2:disable-tests
Oct 26, 2021
Merged

Dumb: disable tests that failed once#3413
guedou merged 1 commit intosecdev:masterfrom
gpotter2:disable-tests

Conversation

@gpotter2
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 18, 2021

Codecov Report

Merging #3413 (71fb082) into master (2519bf1) will decrease coverage by 0.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3413      +/-   ##
==========================================
- Coverage   85.91%   85.45%   -0.46%     
==========================================
  Files         275      275              
  Lines       56863    56863              
==========================================
- Hits        48853    48593     -260     
- Misses       8010     8270     +260     
Impacted Files Coverage Δ
scapy/contrib/isotp/isotp_soft_socket.py 39.56% <0.00%> (-44.49%) ⬇️
scapy/sendrecv.py 80.70% <0.00%> (-4.31%) ⬇️
scapy/contrib/isotp/isotp_utils.py 91.89% <0.00%> (-1.09%) ⬇️
scapy/arch/windows/__init__.py 67.73% <0.00%> (-0.57%) ⬇️
scapy/layers/ntp.py 84.59% <0.00%> (-0.28%) ⬇️
scapy/automaton.py 75.10% <0.00%> (-0.14%) ⬇️
scapy/fields.py 91.47% <0.00%> (-0.06%) ⬇️
scapy/layers/inet6.py 88.36% <0.00%> (+0.05%) ⬆️

@polybassa
Copy link
Copy Markdown
Contributor

Could you please merge the cleanup PR #3379 and #3352. I would like to use those PRs during further investigations of these flaky tests.

@polybassa polybassa mentioned this pull request Oct 20, 2021
Copy link
Copy Markdown
Member

@guedou guedou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@polybassa do you agree with these changes?

@polybassa
Copy link
Copy Markdown
Contributor

polybassa commented Oct 26, 2021 via email

@guedou guedou merged commit 5cc1390 into secdev:master Oct 26, 2021
@gpotter2 gpotter2 deleted the disable-tests branch October 27, 2021 08:03
@gpotter2 gpotter2 added this to the 2.5.0 milestone Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants