Add TestSocket as individual file #3379
Merged
gpotter2 merged 25 commits intosecdev:masterfrom Oct 19, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3379 +/- ##
==========================================
- Coverage 85.96% 85.93% -0.03%
==========================================
Files 275 275
Lines 56824 56824
==========================================
- Hits 48849 48833 -16
- Misses 7975 7991 +16
|
Contributor
Author
|
If possible, can this PR get merged soon? |
This was referenced Sep 30, 2021
600add2 to
2df831b
Compare
Contributor
Author
|
Can this PR get merged? |
guedou
previously approved these changes
Oct 5, 2021
Contributor
Author
|
This was my initial idea, but I don't know how to make the import correct in this case.
On October 5, 2021 6:53:48 PM GMT+02:00, Guillaume Valadon ***@***.***> wrote:
***@***.*** approved this pull request.
…
> @@ -0,0 +1,108 @@
+# This file is part of Scapy
Do you think that this could be moved under `./test/` ?
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
#3379 (review)
|
076c3b0 to
9224d04
Compare
Contributor
Author
guedou
previously approved these changes
Oct 11, 2021
gpotter2
reviewed
Oct 11, 2021
…ce_mockup from various unit tests
9224d04 to
444b2b5
Compare
gpotter2
reviewed
Oct 11, 2021
This was referenced Oct 12, 2021
gpotter2
approved these changes
Oct 19, 2021
Contributor
Author
|
Thanks for the merge.
--
Viele Grüße
Nils Weiß
…On October 19, 2021 9:59:44 AM GMT+02:00, gpotter2 ***@***.***> wrote:
Merged #3379 into master.
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
#3379 (comment)
|
bzalkilani
pushed a commit
to bzalkilani/scapy
that referenced
this pull request
Jun 12, 2022
* Add TestSocket as individual file and remove the execution of interface_mockup from various unit tests * add contrib module description * add import to isotp_soft_socket.uts * add testsocket unit test * increase timeouts * add print * execute testsocket tests first * add debug code * add further test * simplify test * Bugfix in sendrecv * debug CAN layer unit test * try fix of can.uts * cleanup * increase timeouts * increase timeouts * cleanup * fix test * moved testsocket into /test/ * fix tox * add __init__.py * fix gmlanutils * applied feedback * fix testsocket * add timeout to join()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And remove the execution of interface_mockup from various unit tests
This makes the tests cleaner and excludes any interference's because of the code previously executed in interface_mockup. Also the TestSocket is typed.