Drop comparison /w PHP_FLOAT_EPSILON#4972
Merged
sebastianbergmann merged 1 commit intosebastianbergmann:8.5from Sep 14, 2022
mvorisek:patch-1
Merged
Drop comparison /w PHP_FLOAT_EPSILON#4972sebastianbergmann merged 1 commit intosebastianbergmann:8.5from mvorisek:patch-1
PHP_FLOAT_EPSILON#4972sebastianbergmann merged 1 commit intosebastianbergmann:8.5from
mvorisek:patch-1
Conversation
Contributor
Author
|
marking as draft, the one failing test should fail - https://3v4l.org/rIJBO, must be put everywhere where float to string is casted (for print, for weak comparison, ...) |
This was referenced Sep 14, 2022
Contributor
Author
|
PR is done |
sebastianbergmann
pushed a commit
that referenced
this pull request
Sep 15, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4966
The removed code is residual from 136fae3 and even a difference by
PHP_FLOAT_EPSILONshould be reported as a failure.The
PHP_FLOAT_EPSILONconstant equals to2.220446049250313E-16(see 3v4l link in a post below) and is usable only when theabs(a - b)is done on normalized values, but when done so, the comparison is useless or satisfied because of the normalization rounding error solely. On the other side, imagine comparing very small numbers like1e-100and1e-200. The difference between these two normalized values is astronomically large, but currently the phpunit handles such numbers as same!