Mocking an interface that extends another interface forgets to mock its own methods#3604
Merged
sebastianbergmann merged 1 commit intosebastianbergmann:7.5from Apr 22, 2019
morozov:issues/3596
Merged
Mocking an interface that extends another interface forgets to mock its own methods#3604sebastianbergmann merged 1 commit intosebastianbergmann:7.5from morozov:issues/3596
sebastianbergmann merged 1 commit intosebastianbergmann:7.5from
morozov:issues/3596
Conversation
… mock its own methods
Codecov Report
@@ Coverage Diff @@
## 7.5 #3604 +/- ##
============================================
+ Coverage 83.41% 83.43% +0.01%
- Complexity 3632 3636 +4
============================================
Files 143 143
Lines 9671 9682 +11
============================================
+ Hits 8067 8078 +11
Misses 1604 1604
Continue to review full report at Codecov.
|
Owner
|
Thanks! |
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 16, 2019
1. Got rid of hard-coded exception mocks in favor of PHPUnit-generated ones. 2. Reworked AbstractDriverTest::testConvertsException() to use a data provider to make testing all types of exceptions independent. 3. Updated PHPUnit since the reworked code relies on sebastianbergmann/phpunit#3604 and sebastianbergmann/phpunit#3694.
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 16, 2019
1. Got rid of hard-coded exception mocks in favor of PHPUnit-generated ones. 2. Reworked AbstractDriverTest::testConvertsException() to use a data provider to make testing all types of exceptions independent. 3. Updated PHPUnit since the reworked code relies on sebastianbergmann/phpunit#3604 and sebastianbergmann/phpunit#3694.
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 16, 2019
1. Got rid of hard-coded exception mocks in favor of PHPUnit-generated ones where possible. 2. Reworked AbstractDriverTest::testConvertsException() to use a data provider to make testing all types of exceptions independent. 3. Updated PHPUnit since the reworked code relies on sebastianbergmann/phpunit#3604.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3596.