Only prevent serialization of the Closure object.#352
Merged
sebastianbergmann merged 1 commit intoSep 26, 2011
Conversation
Instead of preventing the serialization of all callable values (such as names of functions or those created by create_function), it's better to only prevent the serialization of the Closure object.
sebastianbergmann
added a commit
that referenced
this pull request
Sep 26, 2011
Only prevent serialization of the Closure object.
Contributor
Author
|
@sebastianbergmann Could this also be cherry picked onto the 3.5 branch? |
Owner
|
There will be no more PHPUnit 3.5 releases. |
Contributor
Author
|
Yes, but the bug was created (01aa347) between 3.5.15 tag and the head 3.5 branch, which means people pulling 3.5 branch will not get this bug fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of preventing the serialization of all callable values (such as names of functions or those created by create_function), it's better to only prevent the serialization of the Closure object.
The reason I ran into this problem is a value in
$GLOBALSwas"_"which is a callable function when gettext is installed. Even though the string value had nothing to do with the function which has the same name.