Skip to content

Implements #3048 - XML configuration is validated against the schema#3066

Closed
theseer wants to merge 3 commits intosebastianbergmann:masterfrom
theseer:implemment-3048
Closed

Implements #3048 - XML configuration is validated against the schema#3066
theseer wants to merge 3 commits intosebastianbergmann:masterfrom
theseer:implemment-3048

Conversation

@theseer
Copy link
Copy Markdown
Collaborator

@theseer theseer commented Apr 6, 2018

No description provided.

Copy link
Copy Markdown
Collaborator

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sebastianbergmann sebastianbergmann added this to the PHPUnit 7.2 milestone Apr 6, 2018
@sebastianbergmann sebastianbergmann added the type/enhancement A new idea that should be implemented label Apr 6, 2018
@sebastianbergmann
Copy link
Copy Markdown
Owner

Merged manually, thanks.

@theseer theseer deleted the implemment-3048 branch April 6, 2018 13:29
owenvoke added a commit to owenvoke/skeleton-php that referenced this pull request Jun 13, 2018
Since PHPUnit v7.2.0, the XML configuration files are now validated
against the XSD file for PHPUnit. This throws an error when including
the 'charset', 'yui' and 'highlight' properties on a 'log' entry.

Source: sebastianbergmann/phpunit#3066
jrfnl added a commit to PHPCompatibility/PHPCompatibility that referenced this pull request Jul 24, 2018
As of PHPUnit 7.2 the XML configuration is validated against the XSD and throws a warning.

The `<log>` element should, according to the PHPUnit manual, be nested within a `<logging>` element.

```
PHPUnit 7.2.7 by Sebastian Bergmann and contributors.
  Warning - The configuration file did not pass validation!
  The following problems have been detected:
  Line 14:
  - Element 'log': This element is not expected.
  Test results may not be as expected.
```
From: https://travis-ci.org/PHPCompatibility/PHPCompatibility/jobs/407612965#L799-L805

Refs:
* https://phpunit.readthedocs.io/en/7.1/configuration.html#logging
* https://phpunit.de/manual/5.7/en/appendixes.configuration.html#appendixes.configuration.logging
* sebastianbergmann/phpunit#3066
* https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-7.2.md#720---2018-06-01
owenvoke added a commit to owenvoke/skeleton-php that referenced this pull request Jun 11, 2019
Since PHPUnit v7.2.0, the XML configuration files are now validated
against the XSD file for PHPUnit. This throws an error when including
the 'charset', 'yui' and 'highlight' properties on a 'log' entry.

Source: sebastianbergmann/phpunit#3066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/enhancement A new idea that should be implemented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants