Fix insulated tests with phpdbg#1956
Merged
Merged
Conversation
Contributor
|
Nice fix. 👍 |
Owner
|
Thanks. I do think, though, that this should go into the |
Contributor
Author
|
It could but it's not trivial: -d options needs to be before the eval-stdin.php on the command line, which means that simple concatenation doesn't work... |
Owner
|
Okay. Sounds like one more reason to work on #1342 then. |
Contributor
|
This, … well https://bugs.php.net/73484 This doesn't fix the bug, it just ends up not running the tests at all due to the use of php://input instead of php://stdin. |
Owner
|
Pull requests welcome! :-) Truth be told, neither process isolation nor PHPDBG compatibility are high priority topics for me. |
bwoebi
added a commit
to bwoebi/phpunit
that referenced
this pull request
Nov 13, 2016
Contributor
|
Yeah, see #2356 ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1955