Skip to content

Follow-up to #1351: Restore TestFailure::failedTest()#1359

Merged
whatthejeff merged 1 commit into
sebastianbergmann:masterfrom
sun:result-isolation-bc
Jul 27, 2014
Merged

Follow-up to #1351: Restore TestFailure::failedTest()#1359
whatthejeff merged 1 commit into
sebastianbergmann:masterfrom
sun:result-isolation-bc

Conversation

@sun

@sun sun commented Jul 27, 2014

Copy link
Copy Markdown
Contributor

Resolves #1351: Follow-up to restore backwards-compatibility for test Result printer implementations that rely on TestFailure::failedTest().

Example: Codeception/Codeception#1248

Requires #1360 to identify whether the failing test operates in process isolation.

Comment thread src/Framework/TestCase.php Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing this since we've already merged #1360?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

whatthejeff added a commit that referenced this pull request Jul 27, 2014
Follow-up to #1351: Restore TestFailure::failedTest()
@whatthejeff whatthejeff merged commit 8a68c88 into sebastianbergmann:master Jul 27, 2014
@whatthejeff

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Process isolation TestResult contains serialized test class upon test failure/exception

2 participants