Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sds/overcommit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 43e17fb
Choose a base ref
...
head repository: sds/overcommit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 88bee08
Choose a head ref
  • 2 commits
  • 13 files changed
  • 2 contributors

Commits on Feb 16, 2025

  1. Restore ability to specify "gemfile: false" in config (#863) 

    Setting `gemfile: false` in `.overcommit.yml` is supposed to disable
Bundler. However, a recently-introduced bug causes `false` to be
interpreted as the name of the gemfile. Bundler looks for a gemfile
named "false", which fails, leading overcommit's hooks to crash.

This PR fixes the bug by adjusting the regex used to parse the
`gemfile:` line in the config. Now, `false` is no longer interpreted as
a gemfile name.

I added an integration test to verify the fix.

Fixes #862
    @mattbrictson
    mattbrictson authored Feb 16, 2025
    Configuration menu
    Copy the full SHA
    3db733e View commit details
    Browse the repository at this point in the history

  2. Cut version 0.67.0 (#864)

    @sds
    sds authored Feb 16, 2025
    Configuration menu
    Copy the full SHA
    88bee08 View commit details
    Browse the repository at this point in the history
Loading