Skip to content

Conversation

@olilarkin
Copy link
Contributor

@olilarkin olilarkin commented May 29, 2023

This PR

  • Replaces graphics resources with @1x, @2x, @3x bitmaps from Evan's original PSD file
  • Replaces some widgets with SVGs
  • Changes the look of the about box, adds some text
  • Implements the title with a vector control, adding the font
  • Cleans up layout and the code a lot!
  • Adds a color picker for the highlight color. Currently the color is not saved!
  • Adds NAMMeterControl and reworks NAMFileControl...
NAM-colors-480.mov

@olilarkin olilarkin force-pushed the rework-bitmap-controls branch 3 times, most recently from 6ad6259 to 0ede6d7 Compare May 29, 2023 20:54
@olilarkin olilarkin force-pushed the rework-bitmap-controls branch 2 times, most recently from 75a83d9 to 3f4d4dc Compare June 18, 2023 05:19
@olilarkin olilarkin force-pushed the rework-bitmap-controls branch 3 times, most recently from c7fbff2 to 98cea11 Compare June 25, 2023 12:59
@olilarkin olilarkin force-pushed the rework-bitmap-controls branch 8 times, most recently from 1e1b826 to 0f8ea3b Compare June 25, 2023 19:45
@olilarkin olilarkin marked this pull request as ready for review June 25, 2023 19:47
@sdatkinson sdatkinson merged commit b6fb6ea into sdatkinson:main Jul 1, 2023
sdatkinson added a commit that referenced this pull request Jul 1, 2023
sdatkinson added a commit that referenced this pull request Jul 1, 2023
@sdatkinson
Copy link
Owner

Sorry for the quick trigger finger & revert in #316.

I forget where I noted this (don't see it on this PR?) but I could have sworn I said somewhere that I don't think it's wise to put in the color-picking functionality until we have it saving so that it shows back up OnUIOpen and when restoring projects from disk.

I also recall discussing how adding that info to the serialized state would disrupt folks' existing presets. Thinking through that, I'd like to be able to let development proceed when incremental improvements can be merged, even though the full feature might need more work until it's ready to ship in a release. I'm considering adding a v0.8 branch to merge these sorts of things in that will come in the next minor version bump in case there are things that can be released with more incremental version bumps (i.e. minimize the number of releases that disrupt users). The other option is to put in a feature flag.

I haven't thought it all the way through, but I wanted to at least explain my thinking on this so far.

@olilarkin
Copy link
Contributor Author

olilarkin commented Jul 1, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants