-
Notifications
You must be signed in to change notification settings - Fork 192
Rework bitmap controls #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6ad6259 to
0ede6d7
Compare
75a83d9 to
3f4d4dc
Compare
c7fbff2 to
98cea11
Compare
1e1b826 to
0f8ea3b
Compare
0f8ea3b to
4e30a2b
Compare
This reverts commit b6fb6ea.
|
Sorry for the quick trigger finger & revert in #316. I forget where I noted this (don't see it on this PR?) but I could have sworn I said somewhere that I don't think it's wise to put in the color-picking functionality until we have it saving so that it shows back up I also recall discussing how adding that info to the serialized state would disrupt folks' existing presets. Thinking through that, I'd like to be able to let development proceed when incremental improvements can be merged, even though the full feature might need more work until it's ready to ship in a release. I'm considering adding a I haven't thought it all the way through, but I wanted to at least explain my thinking on this so far. |
|
It’s very simple to comment out the Color picker for now if that’s the only
reason?
…On Sat, 1 Jul 2023 at 03:39, Steven Atkinson ***@***.***> wrote:
Sorry for the quick trigger finger & revert in #316
<#316>.
I forget where I noted this (don't see it on this PR?) but I could have
sworn I said somewhere that I don't think it's wise to put in the
color-picking functionality until we have it saving so that it shows back
up OnUIOpen and when restoring projects from disk.
I also recall discussing how adding that info to the serialized state
would disrupt folks' existing presets. Thinking through that, I'd like to
be able to let development proceed when incremental improvements can be
merged, even though the full feature might need more work until it's ready
to ship in a release. I'm considering adding a v0.8 branch to merge these
sorts of things in that will come in the next minor version bump in case
there are things that can be released with more incremental version bumps
(i.e. minimize the number of releases that disrupt users). The other option
is to put in a feature flag.
I haven't thought it all the way through, but I wanted to at least explain
my thinking on this so far.
—
Reply to this email directly, view it on GitHub
<#270 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFACLS4GL3DWFSE24B3KHTXN55WTANCNFSM6AAAAAAYTFAZKU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This PR
NAM-colors-480.mov